Skip to content

Convey secure boot specific considerations #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 10, 2022
Merged

Convey secure boot specific considerations #177

merged 6 commits into from
Nov 10, 2022

Conversation

bbyykk
Copy link
Contributor

@bbyykk bbyykk commented Nov 10, 2022

I create a topic branch and hope this time could go more smoothly

jserv
jserv requested changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should rebase the latest master branch and squash the commits using git rebase -i.

@jserv jserv requested a review from linD026 November 10, 2022 09:42
@jserv jserv changed the title Topic/secure boot Convey secure boot specific considerations Nov 10, 2022
@bbyykk bbyykk closed this by deleting the head repository Nov 10, 2022
@jserv
Copy link
Contributor

jserv commented Nov 10, 2022

@bbyykk, You don't have to close this pull request. Instead, use git push --force.

@jserv jserv reopened this Nov 10, 2022
linD026
linD026 approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@linD026 linD026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jserv jserv merged commit 9c25e59 into sysprog21:master Nov 10, 2022
@jserv
Copy link
Contributor

jserv commented Nov 10, 2022

Thank @bbyykk for contributing. Next time, you shall practice git skills.

fengjixuchui added a commit to fengjixuchui/lkmpg that referenced this pull request Nov 23, 2022
@fengjixuchui
Merge pull request #9 from sysprog21/master
d15f110 
Convey secure boot specific considerations (sysprog21#177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jserv jserv jserv requested changes

@linD026 linD026 linD026 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbyykk @jserv @linD026