Cleanup redundant workflow step, fix release body and timestamp #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7ee66c5.
This ensures the latest commit message and timestamp can be correctly included in the release.
|
Thank @ekangmonyet for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a redundant step from existing workflow and addresses a minor issue when publishing a "nightly" release using the current workflow.
Since softprops/action-gh-release#134 is upstreamed, #29 is no longer needed and is reverted as the assets file can be replaced correctly. Note that the current behavior of the action will remove all existing assets and replace it with only the files listed.
Currently, the release body and timestamp is not updated due to the update-or-create logic, and it is not possible to update the timestamp of a release using any existing Github API without recreating the release (related issue: softprops/action-gh-release#171). The release body is not updated as the tag already exists thus the current commit will not be re-tagged. Removing both the existing release and tag triggers the creation path which update the body, timestamp and also re-point
latesttag to the current commit.The
Delete old releasestep may be removed if softprops/action-gh-release#181 is merged in the future.