Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Dockerized pdf build in Github Actions #28

Merged
merged 1 commit into from
Aug 1, 2021

Conversation

ekangmonyet
Copy link
Contributor

@ekangmonyet ekangmonyet commented Aug 1, 2021

Build and release a pdf after every push to master using texlive/texlive docker image.
This PR is meant to be scope limited to serve as a foundation for #15 and #25.

Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the git commit message.
See https://chris.beams.io/posts/git-commit/

@ekangmonyet ekangmonyet requested a review from jserv August 1, 2021 10:39
@ekangmonyet ekangmonyet changed the title Dockerized pdf build in Github Actions WIP: Dockerized pdf build in Github Actions Aug 1, 2021
@ekangmonyet
Copy link
Contributor Author

ekangmonyet commented Aug 1, 2021

Issue when replacing the release asset (see: https://github.com/ekangmonyet/lkmpg/actions/runs/1087205429)

Update:
Hope softprops/action-gh-release#134 can resolve the issue.

@ekangmonyet ekangmonyet force-pushed the master branch 3 times, most recently from 03a8b2d to f1b17e6 Compare August 1, 2021 11:18
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fillename ".github/workflows/main.yml" is not so meaningful. Revise it.

@ekangmonyet ekangmonyet force-pushed the master branch 3 times, most recently from c224380 to 2bd40e7 Compare August 1, 2021 11:27
@jserv
Copy link
Contributor

jserv commented Aug 1, 2021

Change filename from release_pdf_github.yml to generate_docs.yml or generate_pdf.yml.

Add a new Github Action to build and release the pdf file after every
push to master.  Using texlive/texlive docker image for reproducibility
and also forward compability with tools like make4ht for future builds.

Progress sysprog21#27 - Reproducible TeX build environment using Docker
@jserv jserv merged commit 0fce98f into sysprog21:master Aug 1, 2021
@jserv
Copy link
Contributor

jserv commented Aug 1, 2021

Thank @ekangmonyet for contributing! I amended the commit message slightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants