Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect number display in calculator when reach its maximum length #25

Closed
Damien-Chen opened this issue Jul 29, 2024 · 0 comments
Closed

Incorrect number display in calculator when reach its maximum length #25

Damien-Chen opened this issue Jul 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Damien-Chen
Copy link
Contributor

image

As the above image show, the current maximum length of number nine digit, at that time, when press any digit button, the number just display randomly as the following image show.
image

In general, when reach the maxium length, the number should retain no change if the next input is still digit until clear or perform other operation.
@jserv jserv added the bug Something isn't working label Aug 22, 2024
@Bennctu Bennctu mentioned this issue Aug 22, 2024
Merged
Bennctu added a commit to Bennctu/mado that referenced this issue Aug 22, 2024
@Bennctu
calc: Set maximum digit length to 9.
a491683 
The type of calc->stack[0] is int,
and the maximum value for an int is 2,147,483,647.
Conservatively, we ensure that when the length reaches 9 digits,
pressing the digit button will not increase the number of digits.
Close sysprog21#25
Bennctu added a commit to Bennctu/mado that referenced this issue Aug 22, 2024
@Bennctu
calc: Set maximum digit length to 9.
8bc23c0 
The type of calc->stack[0] is int,
and the maximum value for an int is 2,147,483,647.
Conservatively, we ensure that when the length reaches 9 digits,
pressing the digit button will not increase the number of digits.
Close sysprog21#25
@jserv jserv closed this as completed in fd3e451 Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jserv @Damien-Chen