Support Linux framebuffer and input system #15

shengwen-tw · 2024-07-24T10:17:28Z

This pull request introduces Linux framebuffer backend and mouse event handling for Mado.

To test the introduced feature:

Press Ctrl+Alt+F3 to switch to new virtual terminal.
Run Mado with the following command:

$ sudo ./demo-fbdev

The user should see the following result on the screen:

After finished testing, the user can switch back to the desktop with Ctrl+Alt+F1.

Makefile

backend/fb.c

shengwen-tw · 2024-07-27T07:26:17Z

I believe we need to modify the twin_create() interface to support passing device path to the Linux framebuffer backend.
So far, I haven't found an elegant solution for this.
If you have any insights on this issue, please let me know.

jserv · 2024-07-27T07:30:25Z

I believe we need to modify the twin_create() interface to support passing device path to the Linux framebuffer backend.
So far, I haven't found an elegant solution for this.

Simply use environment variable such as "FRAMEBUFFER".

jserv

Always use "fbdev" instead of ambiguous “fb" in all occurrences.

shengwen-tw · 2024-07-27T10:14:29Z

We can now run sample program with Linux framebuffer using:

sudo FRAMEBUFFER=/dev/fb0 ./demo-fbdev

backend/fbdev.c

README.md

Makefile

README.md

jserv

Refine the callback functions passing to twin_screen_create.

backend/fbdev.c

README.md

backend/fbdev.c

jserv

Rebase the latest main branch, which contains a preliminary mouse manipulation feature, meaning that the cursor can be rendered along with input events supported via the Linux input subsystem.

shengwen-tw · 2024-08-12T14:49:52Z

It is quite interesting that seems Ubuntu allocates VT2 for Wayland or X11 server (Not sure about other distributions):

$ ps -aux | grep tty
shengwen    1509  0.0  0.0 171148  5376 tty2     Ssl+ 22:33   0:00 /usr/libexec/gdm-wayland-session env GNOME_SHELL_SESSION_MODE=ubuntu /usr/bin/gnome-session --session=ubuntu

This implies that Ctrl+Alt+Fn does not necessary switch to VT n directly.

Also, Ctrl+Alt+F1 is essentially designed for switching to the VT of the desktop graphics environment (i.e., VT2), and Ctrl+Alt+F2 is not assigned with functionality.

Reference: What is the purpose of /usr/lib/xorg/Xorg vt2 -displayfd 3?

jserv · 2024-08-12T15:58:33Z

This implies that Ctrl+Alt+Fn does not necessary switch to VT n directly.

The composite key to trigger VT switching is not fixed, meaning the behavior can vary significantly between Linux distributions. Mado is not necessarily designed to co-exist with the X server or Wayland display server. Instead, it is intended to operate with the Linux framebuffer, similar to FBUI. You can include a note about VT switching without specifying the exact keystrokes.

backend/fbdev.c

jserv

Rebase the latest main branch and utilize the logging functions.

README.md

backend/fbdev.c

backend/linux_input.c

jserv · 2024-09-17T03:48:29Z

backend/linux_input.c

+    return NULL;
+}
+
+static bool dummy(int file, twin_file_op_t ops, void *closure)


The dummy is a hack though.

backend/fbdev.c

jserv · 2024-09-17T13:31:17Z

backend/linux_input.c

+#endif
+
+    /* Start event handling thread */
+    if (pthread_create(&tm->evdev_thread, NULL, twin_linux_evdev_thread, tm)) {


TWIN (and by extension, Mado) was designed to operate in single-threaded environments, and it is not reasonable to assume POSIX threads are available everywhere. Be sure to note the use of POSIX threads in the git commit messages for the Linux framebuffer backend. Coroutines could potentially be used as an alternative.

Reference on Coroutine in C:
#4 (comment)

backend/fbdev.c

jserv

Append Close #3 at the end of the git commit messages. You should refine the commit message to clearly state what has been accomplished and outline any remaining tasks for further improvements.

This commit adds a Linux framebuffer backend to Mado, utilizing framebuffer and event devices for basic input and display. Note that though TWIN (and by extension, Mado) was designed to operate in single-threaded environments, the Linux framebuffer backend in Mado currently uses POSIX thread to manage input system events. Coroutines could potentially be used as an alternative. Follow-up tasks: 1. Protect mouse event update with mutex (see linux_input.c) 2. Fix an existing unexpected termination bug (see linux_input.c) 3. Support DRM/KMS backend 4. Support hot-pluging and removal of input devices via udev 5. Refine event handling (i.e., remove POSIX thread if possible) Close sysprog21#3

jserv · 2024-10-06T13:07:44Z

Thank @shengwen-tw for contributing!

shengwen-tw mentioned this pull request Jul 24, 2024

Implement Linux framebuffer backend #3

Closed

jserv reviewed Jul 24, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

shengwen-tw force-pushed the main branch from 4c2376f to a1e5702 Compare July 24, 2024 13:11

jserv force-pushed the main branch from 55783e5 to d15970f Compare July 24, 2024 21:33

This comment was marked as outdated.

Sign in to view

jserv reviewed Jul 24, 2024

View reviewed changes

backend/fb.c Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

shengwen-tw force-pushed the main branch from a1e5702 to 9caaa25 Compare July 27, 2024 07:20

jserv requested changes Jul 27, 2024

View reviewed changes

shengwen-tw force-pushed the main branch 3 times, most recently from f76271e to c8bb608 Compare July 27, 2024 10:13

jserv reviewed Jul 27, 2024

View reviewed changes

backend/fbdev.c Outdated Show resolved Hide resolved

jserv reviewed Jul 27, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

jserv reviewed Jul 27, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

jserv reviewed Jul 27, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

jserv requested changes Jul 28, 2024

View reviewed changes

backend/fbdev.c Outdated Show resolved Hide resolved

backend/fbdev.c Show resolved Hide resolved

backend/fbdev.c Outdated Show resolved Hide resolved

shengwen-tw force-pushed the main branch from c8bb608 to 55d89b1 Compare July 28, 2024 15:54

This comment was marked as outdated.

Sign in to view

jserv reviewed Jul 28, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

jserv reviewed Jul 28, 2024

View reviewed changes

backend/fbdev.c Outdated Show resolved Hide resolved

shengwen-tw force-pushed the main branch from 55d89b1 to 1a69451 Compare July 28, 2024 16:11

This comment was marked as resolved.

Sign in to view

shengwen-tw force-pushed the main branch 2 times, most recently from 1cfa91e to 888355f Compare July 28, 2024 16:19

jserv requested changes Jul 30, 2024

View reviewed changes

sysprog21 deleted a comment from shengwen-tw Jul 30, 2024

shengwen-tw force-pushed the main branch from cf84ff1 to 84cdaf6 Compare August 12, 2024 14:55

jserv reviewed Aug 12, 2024

View reviewed changes

backend/fbdev.c Outdated Show resolved Hide resolved

jserv requested changes Sep 14, 2024

View reviewed changes

shengwen-tw force-pushed the main branch from 84cdaf6 to a1cb615 Compare September 16, 2024 11:21

jserv reviewed Sep 16, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

jserv reviewed Sep 16, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

jserv reviewed Sep 16, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

jserv reviewed Sep 16, 2024

View reviewed changes

backend/fbdev.c Outdated Show resolved Hide resolved

shengwen-tw force-pushed the main branch from a1cb615 to 52e7fab Compare September 16, 2024 15:08

This comment was marked as outdated.

Sign in to view

shengwen-tw force-pushed the main branch from 52e7fab to 442f72d Compare September 17, 2024 03:27

jserv reviewed Sep 17, 2024

View reviewed changes

backend/linux_input.c Outdated Show resolved Hide resolved

jserv reviewed Sep 17, 2024

View reviewed changes

backend/linux_input.c

return NULL;

}

static bool dummy(int file, twin_file_op_t ops, void *closure)

Copy link

Contributor

jserv Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dummy is a hack though.

shengwen-tw force-pushed the main branch from 442f72d to 0937c47 Compare September 17, 2024 05:59

jserv reviewed Sep 17, 2024

View reviewed changes

backend/fbdev.c Outdated Show resolved Hide resolved

jserv reviewed Sep 17, 2024

View reviewed changes

backend/fbdev.c Outdated Show resolved Hide resolved

jserv reviewed Sep 17, 2024

View reviewed changes

shengwen-tw force-pushed the main branch from 0937c47 to 2aa0b81 Compare September 24, 2024 04:36

jserv reviewed Sep 25, 2024

View reviewed changes

backend/fbdev.c Outdated Show resolved Hide resolved

jserv reviewed Sep 25, 2024

View reviewed changes

backend/fbdev.c Show resolved Hide resolved

shengwen-tw force-pushed the main branch from 2aa0b81 to f27a255 Compare October 2, 2024 13:34

jserv requested changes Oct 2, 2024

View reviewed changes

shengwen-tw force-pushed the main branch from f27a255 to a70dce4 Compare October 6, 2024 12:49

shengwen-tw added 2 commits October 6, 2024 20:50

Mention sample program execution with Linux framebuffer and input system

468eb6a

shengwen-tw force-pushed the main branch from a70dce4 to 468eb6a Compare October 6, 2024 12:51

jserv merged commit 980bd4c into sysprog21:main Oct 6, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Linux framebuffer and input system #15

Support Linux framebuffer and input system #15

shengwen-tw commented Jul 24, 2024 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

shengwen-tw commented Jul 27, 2024

jserv commented Jul 27, 2024

jserv left a comment

shengwen-tw commented Jul 27, 2024

jserv left a comment

This comment was marked as outdated.

This comment was marked as resolved.

jserv left a comment

shengwen-tw commented Aug 12, 2024 •

edited

Loading

jserv commented Aug 12, 2024

jserv left a comment

This comment was marked as outdated.

jserv Sep 17, 2024

jserv Sep 17, 2024 •

edited

Loading

shengwen-tw Sep 24, 2024

jserv left a comment

jserv commented Oct 6, 2024

Support Linux framebuffer and input system #15

Support Linux framebuffer and input system #15

Conversation

shengwen-tw commented Jul 24, 2024 • edited Loading

This comment was marked as outdated.

This comment was marked as outdated.

shengwen-tw commented Jul 27, 2024

jserv commented Jul 27, 2024

jserv left a comment

Choose a reason for hiding this comment

shengwen-tw commented Jul 27, 2024

jserv left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as resolved.

jserv left a comment

Choose a reason for hiding this comment

shengwen-tw commented Aug 12, 2024 • edited Loading

jserv commented Aug 12, 2024

jserv left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

jserv Sep 17, 2024

Choose a reason for hiding this comment

jserv Sep 17, 2024 • edited Loading

Choose a reason for hiding this comment

shengwen-tw Sep 24, 2024

Choose a reason for hiding this comment

jserv left a comment

Choose a reason for hiding this comment

jserv commented Oct 6, 2024

shengwen-tw commented Jul 24, 2024 •

edited

Loading

shengwen-tw commented Aug 12, 2024 •

edited

Loading

jserv Sep 17, 2024 •

edited

Loading