Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: WebAssembly action failed when PR merged #400

Closed
ChinYikMing opened this issue Apr 5, 2024 · 1 comment · Fixed by #403
Closed

CI: WebAssembly action failed when PR merged #400

ChinYikMing opened this issue Apr 5, 2024 · 1 comment · Fixed by #403
Assignees
@ChinYikMing

Comments

@ChinYikMing
Copy link
Collaborator

See action
@ChinYikMing ChinYikMing self-assigned this Apr 5, 2024
@ChinYikMing ChinYikMing changed the title WebAssembly CI failed when PR merged CI: WebAssembly action failed when PR merged Apr 5, 2024
ChinYikMing added a commit to ChinYikMing/rv32emu that referenced this issue Apr 5, 2024
@ChinYikMing
Specify token when checking out rv32emu-demo repo
14aa9f3 
See issue: sysprog21#400
@ChinYikMing ChinYikMing mentioned this issue Apr 5, 2024
Merged
ChinYikMing added a commit to ChinYikMing/rv32emu that referenced this issue Apr 5, 2024
@ChinYikMing
CI: Specify token when checking out demo
d855d3e 
The existing WebAssembly CI works on my repository, but it is failed
here. This is very strange but we still have to solve it.

Combining some dicussion in github-push-action's issue and my own
thought, when checking out demo, the persist-credentials is set to
false, thus the token used for further action should be specified.

See issue: sysprog21#400
ChinYikMing added a commit to ChinYikMing/rv32emu that referenced this issue Apr 5, 2024
@ChinYikMing
CI: Specify token when checking out demo
84dc48e 
The existing WebAssembly CI works on my repository, but it is failed
here. This is very strange but we still have to solve it.

Combining some dicussion in github-push-action's issue and my own
thought, when checking out demo, the persist-credentials is set to
false, thus the token used for further action should be specified.

See issue: sysprog21#400
jserv pushed a commit that referenced this issue Apr 5, 2024
@ChinYikMing
CI: Specify token when checking out demo (#401)
a544093 
The existing WebAssembly CI works on personal repository, but it failed
here. This is very strange but we still have to solve it.

Combining some discussion in github-push-action's issue and my own
thought, when checking out demo, the persist-credentials is set to
false, thus the token used for further action should be specified.

See issue: #400
ChinYikMing added a commit to ChinYikMing/rv32emu that referenced this issue Apr 5, 2024
@ChinYikMing
CI: WebAssembly CI test
407e127 
See issue: sysprog21#400
@ChinYikMing
Copy link
Collaborator Author

To access the secrets variable (or token) in actions when merging PR, it is necessary to use pull_request_target instead of pull_request.

ChinYikMing added a commit to ChinYikMing/rv32emu that referenced this issue Apr 5, 2024
@ChinYikMing
CI: Tweak WebAssembly CI event
bbe1cfb 
To access the secrets variable (or token) in pull request event,
it is necessary to use pull_request_target instead of pull_request.

Close: sysprog21#400
@ChinYikMing ChinYikMing mentioned this issue Apr 5, 2024
Merged
@jserv jserv closed this as completed in #403 Apr 5, 2024
jserv pushed a commit that referenced this issue Apr 5, 2024
@ChinYikMing
CI: Tweak WebAssembly event (#403)
3fe3d6c 
To access the secrets variable (or token) in pull request event,
it is necessary to use pull_request_target instead of pull_request.

Close: #400
vestata pushed a commit to vestata/rv32emu that referenced this issue Jan 24, 2025
@ChinYikMing
CI: Tweak WebAssembly event (sysprog21#403)
3995c95 
To access the secrets variable (or token) in pull request event,
it is necessary to use pull_request_target instead of pull_request.

Close: sysprog21#400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChinYikMing ChinYikMing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: Tweak WebAssembly CI event ChinYikMing/rv32emu
1 participant
@ChinYikMing