Fix round_pow2 function for edge cases #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The round_pow2 function was returning incorrect values when the input x was less than or equal to 1. Specifically, it was returning 2 for x=1 when compiled with GCC or Clang, and 0 for x=0 when compiled with other compilers. According to the documentation in syscall.md, both of these cases should return 1. This commit addresses the issue by explicitly handling these edge cases and returning 1.
|
Thank @visitorckw for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The round_pow2 function was returning incorrect values when the input x was less than or equal to 1. Specifically, it was returning 2 for x=1 when compiled with GCC or Clang, and 0 for x=0 when compiled with other compilers. According to the documentation in syscall.md, both of these cases should return 1. This commit addresses the issue by explicitly handling these edge cases and returning 1.