Fix rb_remove() key comparison #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The origin code was erroneously comparing node->data when searching for the node to remove, instead of using the node->key. This commit corrects the comparison to use the node->key, ensuring the proper removal of nodes.
To ensure that the map functions do not rely on node data values when comparing and performing operations, this commit modifies the unit tests for map. It replaces the sequential data values with random values obtained from mt19937_extract().
EagleTw
approved these changes
Oct 16, 2023
|
Thank @visitorckw for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The origin code was erroneously comparing
node->datawhen searchingfor the node to remove, instead of using the
node->key. This PRcorrects the comparison to use the
node->key, ensuring the properremoval of nodes. Also, to ensure that the map functions do not rely on
node data values when comparing and performing operations, this PR
modifies the unit tests for map. It replaces the sequential data values
with random values obtained from
mt19937_extract().Close: #168