Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to resolve Assertion failed: (total_read == rv_get_reg(rv, rv_reg_a2)) #254

Closed
wants to merge 1 commit into from

Conversation

huaxinliao
Copy link
Contributor

@huaxinliao huaxinliao commented Nov 3, 2023

At the outset, I attempted to replicate the issue reported by qwe661234. However, on my PC, everything appeared normal without any errors. To further investigate, I utilized GDB by specifying the build/rv32emu and setting a breakpoint at src/syscall.c:290. My goal was to observe the values of 'total_read' and 'rv_get_reg (rv, rv_reg_a2)' to ascertain whether any discrepancy in these values might have been the root cause of qwe661234's issue. Upon analysis, I discovered that 'total_read' was equal to 0xC, and 'rv_get_reg(rv, rv_reg_a2)' was also 0xC. Consequently, in the assertion 'assert(total_read == rv_get_reg(rv, rv_reg_a2));', the program didn't halt. The link is my debug report.

See #214

@jserv
Copy link
Contributor

jserv commented Nov 3, 2023

I have chedcked the values of total_read and rv_get_reg(rv, rv_reg_a2). The values of total_read and rv_get_reg(rv, rv_reg_a2) are the same

Kindly offer well-articulated remarks on your opinions and proposed modifications. Make them informative.

@jserv jserv requested a review from qwe661234 November 3, 2023 12:12
@jserv jserv changed the title debug (total_read == rv_get_reg(rv, rv_reg_a2)) Attempt to resolve Assertion failed: (total_read == rv_get_reg(rv, rv_reg_a2)) Nov 3, 2023
@visitorckw
Copy link
Collaborator

After git checkout to commit 567660c, I also did not observe the assertion failure mentioned in the issue during my tests. Tested on Ubuntu 22.04.3 LTS.

@jserv
Copy link
Contributor

jserv commented Nov 5, 2023

This pull request seems disconnected from the issue it purports to resolve. Closing it would enable us to give our attention to other pull requests.

@jserv jserv closed this Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants