Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused 'isnanf' and 'isinff' functions #262

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

visitorckw
Copy link
Collaborator

The introduction of SoftFloat for F extension implementation renders 'isnanf' and 'isinff' functions unnecessary. These functions were causing compilation warnings due to being unused.

The commit addresses the following warnings:

src/emulate.c:18:19: warning: unused function 'isinff' [-Wunused-function] static inline int isinff(float x)
^
src/emulate.c:22:19: warning: unused function 'isnanf' [-Wunused-function] static inline int isnanf(float x)
^
2 warnings generated.

This removal eliminates the redundant functions, ensuring a cleaner codebase and resolving the compilation warnings.

Close: #87

The introduction of SoftFloat for F extension implementation renders
'isnanf' and 'isinff' functions unnecessary. These functions were
causing compilation warnings due to being unused.

The commit addresses the following warnings:
src/emulate.c:18:19: warning: unused function 'isinff' [-Wunused-function]
static inline int isinff(float x)
^
src/emulate.c:22:19: warning: unused function 'isnanf' [-Wunused-function]
static inline int isnanf(float x)
^
2 warnings generated.

This removal eliminates the redundant functions, ensuring a cleaner
codebase and resolving the compilation warnings.
@jserv jserv merged commit 66fdca7 into sysprog21:master Nov 11, 2023
20 checks passed
@visitorckw visitorckw deleted the remove-unused-float-function branch November 13, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of floating point library functions
2 participants