Fix softfloat build failure #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| #undef float16_t | ||
| #undef bfloat16_t | ||
| #undef float32_t | ||
| #undef float64_t |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 20.5 rule Note
| #include "softfloat/softfloat.h" | ||
| #undef float16_t |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 20.5 rule Note
| #include "softfloat/softfloat.h" | ||
| #undef float16_t | ||
| #undef bfloat16_t | ||
| #undef float32_t |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 20.5 rule Note
| #include "softfloat/softfloat.h" | ||
| #undef float16_t | ||
| #undef bfloat16_t |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 20.5 rule Note
Replace the usage of the softfloat type 'float32_t' with the custom 'riscv_float_t' type defined within rv32emu. This modification ensures better integration and consistency within the rv32emu codebase.
Addressed compilation errors on macOS/Arm64 arising from conflicts between SoftFloat and SDL headers. The solution involves explicitly defining the conflicting types in SoftFloat to avoid clashes.
visitorckw
force-pushed
the
fix-softfloat-build-failure
branch
from
42c10f6
to
129aca2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed compilation errors on macOS/Arm64 arising from conflicts between SoftFloat and SDL headers. The solution involves explicitly defining the conflicting types in SoftFloat to avoid clashes.
Close: #261