Implement file path sanitation #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cppcheck (reported by Codacy) found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
henrybear327
force-pushed
the
feat/elf_path_check
branch
2 times, most recently
from
c501e2e
to
28f31a1
Compare
jserv
reviewed
Nov 23, 2023
jserv
changed the title
henrybear327
force-pushed
the
feat/elf_path_check
branch
2 times, most recently
from
5b30fbd
to
da86b50
Compare
Merged using a separate commit. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
henrybear327
force-pushed
the
feat/elf_path_check
branch
from
cfe2b3f
to
40e2355
Compare
jserv
reviewed
Nov 23, 2023
henrybear327
force-pushed
the
feat/elf_path_check
branch
from
40e2355
to
e79c32c
Compare
jserv
reviewed
Nov 23, 2023
jserv
reviewed
Nov 23, 2023
jserv
reviewed
Nov 23, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jserv
requested changes
Nov 23, 2023
henrybear327
force-pushed
the
feat/elf_path_check
branch
2 times, most recently
from
d108622
to
52e1dab
Compare
jserv
reviewed
Nov 23, 2023
jserv
reviewed
Nov 23, 2023
henrybear327
force-pushed
the
feat/elf_path_check
branch
from
52e1dab
to
6aabc72
Compare
jserv
reviewed
Nov 23, 2023
jserv
reviewed
Nov 23, 2023
henrybear327
force-pushed
the
feat/elf_path_check
branch
2 times, most recently
from
34daec4
to
6d3bc33
Compare
jserv
reviewed
Nov 23, 2023
henrybear327
force-pushed
the
feat/elf_path_check
branch
2 times, most recently
from
dbd1d4a
to
683a5bc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
henrybear327
force-pushed
the
feat/elf_path_check
branch
from
683a5bc
to
e3108b2
Compare
jserv
reviewed
Nov 23, 2023
jserv
reviewed
Nov 23, 2023
jserv
reviewed
Nov 23, 2023
henrybear327
force-pushed
the
feat/elf_path_check
branch
from
e3108b2
to
a758a35
Compare
jserv
reviewed
Nov 23, 2023
henrybear327
force-pushed
the
feat/elf_path_check
branch
3 times, most recently
from
f889251
to
5c5286b
Compare
|
Is it time to close #137? If so, append |
henrybear327
force-pushed
the
feat/elf_path_check
branch
2 times, most recently
from
1df5044
to
c7d1f74
Compare
Yes. Commit messages changed as requested |
henrybear327
force-pushed
the
feat/elf_path_check
branch
from
c7d1f74
to
ff14419
Compare
jserv
reviewed
Nov 23, 2023
jserv
reviewed
Nov 23, 2023
…21#137) The logic is ported from Golang to C. Reference code: - https://cs.opensource.google/go/go/+/refs/tags/go1.21.4:src/path/path.go;l=70 - https://cs.opensource.google/go/go/+/refs/tags/go1.21.4:src/path/path_test.go Close sysprog21#137
henrybear327
force-pushed
the
feat/elf_path_check
branch
from
ff14419
to
087dd28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #137, the elf path is not sanitized before opening, which might be a security risk. This PR addresses this issue by porting the path sanitation logic from Golang to C.
Reference code: https://cs.opensource.google/go/go/+/refs/tags/go1.21.4:src/path/path.go;l=70
Unit test -> #274