Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the microsecond-to-nanosecond conversion in rv_clock_gettime() #360

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix the microsecond-to-nanosecond conversion in rv_clock_gettime() #360

merged 1 commit into from
May 21, 2024

Conversation

alanjian85
Copy link
Collaborator

A microsecond is 1000 times bigger than a nanosecond (10-6 vs 10-9 seconds). This commit corrects the conversion of microseconds to nanoseconds in rv_clock_gettime() by multiplying tv_usec by 1000 instead of dividing it.

@alanjian85
Fix the microsecond-to-nanosecond conversion in rv_clock_gettime()
bbb377f 
A microsecond is 1000 times bigger than a nanosecond (1e-6 vs 1e-9 seconds).
This commit corrects the conversion of microseconds to nanoseconds in
rv_clock_gettime() by multiplying tv_usec by 1000 instead of dividing it.
@jserv
Copy link
Contributor

jserv commented Feb 26, 2024 •
edited
Loading

The issue with time conversion for rv_clock_gettime has been resolved by @visitorckw, and it is expected that the fix would be included in newlib version 4.4. We need to verify that the prebuilt RISC-V toolchains, especially those maintained by SiFive, incorporate newlib-4.4 into their builds. Once confirmed, we will be able to mandate the proper approach for handling rv_clock_gettime.

@visitorckw
Copy link
Collaborator

See: https://sourceware.org/git/?p=newlib-cygwin.git;a=commit;h=5f15d7c5817b07a6b18cbab17342c95cb7b42be4

@alanjian85 alanjian85 closed this Feb 29, 2024
@jserv
Copy link
Contributor

jserv commented Feb 29, 2024

Let's keep this pull request and wait for prebuilt GNU Toolchain for landing newlib fixes.

@jserv jserv reopened this Feb 29, 2024
@jserv
Copy link
Contributor

jserv commented Apr 6, 2024 •
edited
Loading

Let's keep this pull request and wait for prebuilt GNU Toolchain for landing newlib fixes.

Recent riscv-gnu-toolchain supports newlib 4.4.0, meaning that it is time to adopt this proposed change.

Once the prebuilt GNU Toolchain for RISC-V is ready for downloading, I will merge this pull request and rebuild all ELF files.

@jserv
Copy link
Contributor

jserv commented Apr 26, 2024

Recent riscv-gnu-toolchain supports newlib 4.4.0, meaning that it is time to adopt this proposed change.
Once the prebuilt GNU Toolchain for RISC-V is ready for downloading, I will merge this pull request and rebuild all ELF files.

The Nightly: April 12, 2024 build should include newlib v4.4.0 already.

@jserv jserv merged commit a8aa29e into sysprog21:master May 21, 2024
14 checks passed
@jserv
Copy link
Contributor

jserv commented May 21, 2024

Thank @alanjian85 for contributing!

@visitorckw visitorckw mentioned this pull request May 29, 2024
Merged
@henrybear327 henrybear327 mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visitorckw visitorckw Awaiting requested review from visitorckw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanjian85 @jserv @visitorckw