Implement features used by fenster #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Apr 5, 2024
jserv
changed the title
jserv
requested changes
Apr 5, 2024
fenster-rv32emu, the rv32emu port of the Fenster library, utilizes capabilities not supported by rv32emu currently. These features include customizing window title, retrieving the mouse position and the program quit event. To support these features, the SDL-oriented system calls are refined to give the hosted program additional information and enable typical functions such as changing the title of the displayed window. Note that these changes do not have binary backward compatibility, so all the binary files related to SDL-oriented system calls are updated and recompiled.
|
Thank @alanjian85 for contributing! |
By the way, the fenster-rv32emu repo is still under my personal account. It is better to fork and maintain it under this orgnanization. |
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
The fenster-rv32emu [1], a port of the fenster library for rv32emu, introduces capabilities not previously supported. These features include customizing the window title, capturing mouse position, and detecting program quit events. To accommodate these features, SDL-oriented system calls have been refined, providing the hosted program with additional information and enabling standard functions like changing the window's title. It is important to note that these updates are not backward compatible with previous binaries. Therefore, all binary files associated with SDL-oriented system calls have been updated and recompiled. [1] https://github.com/alanjian85/fenster-rv32emu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fenster-rv32emu, the rv32emu port of the Fenster library, utilizes capabilities not supported by rv32emu currently. These features include customizing window title, retrieving the mouse position and the program quit event. To support these features, the SDL-oriented system calls are refined to give the hosted program additional information and enable typical functions such as changing the title of the displayed window.
Note that these changes do not have binary backward compatibility, so all the binary files related to SDL-oriented system calls are updated and recompiled.