Fix hardcoded sha1sum command and compare sha1 value #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Mar 29, 2024
ChinYikMing
force-pushed
the
sha1
branch
2 times, most recently
from
2d2a909
to
bec6bc6
Compare
jserv
reviewed
Mar 31, 2024
ChinYikMing
force-pushed
the
sha1
branch
4 times, most recently
from
733d515
to
1bb92d2
Compare
jserv
reviewed
Mar 31, 2024
ChinYikMing
force-pushed
the
sha1
branch
5 times, most recently
from
9c8af15
to
f04ba14
Compare
jserv
reviewed
Mar 31, 2024
ChinYikMing
force-pushed
the
sha1
branch
4 times, most recently
from
36fffc3
to
3a3d847
Compare
jserv
reviewed
Mar 31, 2024
Abstract the extractor and verifier to support .zip and .gz compressed files. The $(call) function executes during the expansion, so we have to make all steps inside download-extract-verify to $(call) like, so that they can be run in sequentially. To do that, introducing three more functions which are prologue, download, and epilogue.
|
Thank @ChinYikMing for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.