Streamline rounding modes checks and settings in RV32F #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was observed that the instructions feqs, flts, and fles are not affected by rounding modes in any way. Therefore, remove the unnecessary rounding mode checks and settings associated with these instructions. This optimization aims to avoid potential performance impacts caused by redundant operations related to rounding modes.
jserv
reviewed
Apr 8, 2024
There was a problem hiding this comment.
Benchmarks
| Benchmark suite | Current: 374daeb | Previous: 9408d8c | Ratio |
|---|---|---|---|
Dhrystone |
1741.44 Average DMIPS over 10 runs |
1605.66 Average DMIPS over 10 runs |
0.92 |
Coremark |
1501.415 Average iterations/sec over 10 runs |
1465.346 Average iterations/sec over 10 runs |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
jserv
reviewed
Apr 8, 2024
src/softfloat.h
Outdated
| } | ||
| const uint32_t frm = (rv->csr_fcsr >> 5) & (~(1 << 3)); | ||
|
|
||
| if (rm == 0b111) |
There was a problem hiding this comment.
Add likely or unlikely hint when possible.
Following the removal of rounding mode checks and settings for the feqs, flts, and fles instructions, unify the set_static_rounding_mode() and set_dynamic_rounding_mode() functions into a single function. This consolidation improves code clarity and reduces redundancy in the rounding mode handling code.
visitorckw
force-pushed
the
rv32f-cleanups
branch
from
079ac67
to
374daeb
Compare
|
Thank @visitorckw for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary checks and settings for RV32F instructions (feqs, flts, fles), leading to potential performance improvements. Additionally, unify the set_static_rounding_mode() and set_dynamic_rounding_mode() functions into a single function for better code clarity and reduced redundancy in rounding mode handling.