Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error caused by missing softfloat dependency #423

Merged
merged 1 commit into from
May 4, 2024

Conversation

visitorckw
Copy link
Collaborator

When adding the -j flag to make for faster compilation speeds, it led to the following error:

src/riscv.h:20:10: fatal error: softfloat/softfloat.h: No such file or directory
20 | #include "softfloat/softfloat.h"
| ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

This was due to incorrect dependency settings, where compilation of the source code started before completing the git submodule update, leading to the error. Add appropriate dependency handling to ensure that compilation of the softfloat library is completed before compiling the source code.

When adding the -j flag to make for faster compilation speeds, it led
to the following error:

src/riscv.h:20:10: fatal error: softfloat/softfloat.h: No such file or directory
   20 | #include "softfloat/softfloat.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

This was due to incorrect dependency settings, where compilation of the
source code started before completing the git submodule update, leading
to the error. Add appropriate dependency handling to ensure that
compilation of the softfloat library is completed before compiling the
source code.
@jserv jserv merged commit 5b1a119 into sysprog21:master May 4, 2024
8 checks passed
@jserv
Copy link
Contributor

jserv commented May 4, 2024

Thank @visitorckw for contributing!

@visitorckw visitorckw deleted the fix-softfloat-dependency branch May 4, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants