Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce benchmark.yml #469

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

henrybear327
Copy link
Collaborator

There is an issue with accessing github-token from mail.yml, see https://github.com/sysprog21/rv32emu/actions/runs/9873045064/job/27264462124?pr=467.

The error is Error: 'auto-push' is enabled but 'github-token' is not set. Please give API token to push GitHub pages branch to remote. This wasn't present when the benchmark was in its dedicated file.

The proposal is to move the modified benchmark pipeline back to its original file.

@henrybear327 henrybear327 requested a review from jserv July 10, 2024 11:14
@henrybear327 henrybear327 self-assigned this Jul 10, 2024
@jserv jserv merged commit 9759ad2 into sysprog21:master Jul 10, 2024
7 checks passed
@henrybear327 henrybear327 deleted the ci/benchmark2 branch July 10, 2024 11:38
@henrybear327
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants