Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate doom, quake, and scimark2 builds #480

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

vacantron
Copy link
Collaborator

No description provided.

@jserv jserv changed the title Automate doom, quake, scimark builds Automate doom, quake, and scimark2 builds Aug 28, 2024
docs/prebuilt.md Outdated
@@ -48,8 +49,10 @@ The prebuilt binaries in `rv32emu-prebuilt` are built from the following reposit
- `pi` : See [tests/pi.c](/tests/pi.c)
- `puzzle` : See [tests/puzzle.c](/tests/puzzle.c)
- `qrcode` : See [tests/qrcode.c](/tests/qrcode.c)
- `quake` : See [sysprog21/quake-embedded](https://github.com/sysprog21/quake-embedded)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention RV32F explicitly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current prebuilt binaries are built with -march=rv32im option. I'd like to keep quake been built without F extension for the consistency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SciMark2 should be built in RV32F since it reports a composite score in approximate Mflops (Millions of floating point operations per second).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SciMark2 should be built in RV32F since it reports a composite score in approximate Mflops (Millions of floating point operations per second).

Got it. Should we also build quake with rv32f? I feel the execution is smooth when building with rv32im.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Should we also build quake with rv32f? I feel the execution is smooth when building with rv32im.

Quake needs to be compiled with RV32IMF. Otherwise, it is unlikely to function properly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found quake is already built with RV32IMF within its Makefile. I'll update the document later.

@jserv
Copy link
Contributor

jserv commented Aug 28, 2024

CI reported:

GPG error: https://apt.llvm.org/jammy llvm-toolchain-jammy-17 InRelease:
The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 15CF4D18AF4F7421
E: The repository 'http://apt.llvm.org/jammy llvm-toolchain-jammy-17 InRelease' is not signed.

See Signatures couldn't be verified because the public key is not available: NO_PUBKEY.

@jserv jserv added this to the release-2024.1 milestone Aug 28, 2024
@vacantron
Copy link
Collaborator Author

CI reported:
...
See Signatures couldn't be verified because the public key is not available: NO_PUBKEY.

I think this error was caused by the script from https://apt.llvm.org/llvm.sh. In line 160: wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc. It seems to fail to retrieve the GPG key (maybe the Internet issue?).

@jserv jserv merged commit 48fc077 into sysprog21:master Aug 29, 2024
8 checks passed
@jserv
Copy link
Contributor

jserv commented Aug 29, 2024

Thank @vacantron for contributing!

@vacantron vacantron deleted the prebuilt branch August 29, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants