Fix gdbstub dependency and enable parallel compilation for faster CI #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling with ENABLE_GDBSTUB=1 using the command:
make ENABLE_GDBSTUB=1 -j$(nproc)
The following compilation error occurs:
In file included from src/syscall.c:14:
src/riscv_private.h:11:10: fatal error: mini-gdbstub/include/gdbstub.h: No such file or directory
11 | #include "mini-gdbstub/include/gdbstub.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:213: build/syscall.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from src/softfloat.h:11,
from src/emulate.c:19:
src/riscv_private.h:11:10: fatal error: mini-gdbstub/include/gdbstub.h: No such file or directory
11 | #include "mini-gdbstub/include/gdbstub.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:212: build/emulate.o] Error 1
In file included from src/riscv.c:28:
src/riscv_private.h:11:10: fatal error: mini-gdbstub/include/gdbstub.h: No such file or directory
11 | #include "mini-gdbstub/include/gdbstub.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
The error is due to the improper handling of the gdbstub library
dependency in the Makefile. This patch ensures that the gdbstub library
is correctly compiled before source files that depend on it.
Parallel compilation with -j$(nproc) is introduced to the default build and gdbstub tests. By utilizing all available CPU cores, this change improves the speed of the build and testing process, reducing CI execution time.
visitorckw
force-pushed
the
fix-gdbstub-build
branch
from
e488d65
to
b4a2d77
Compare
|
Thank @visitorckw for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a compilation error related to the missing gdbstub dependency in the Makefile when building with ENABLE_GDBSTUB=1, ensuring the gdbstub library is correctly compiled before the dependent source files to prevent missing header file issues. Additionally, it introduces parallel compilation using -j$(nproc) for both the default build and gdbstub tests, utilizing all available CPU cores to accelerate the build and testing processes, reducing CI execution time.