Improve fmin/fmax #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Sep 8, 2022
jserv
reviewed
Sep 8, 2022
jserv
requested changes
Sep 8, 2022
jserv
requested changes
Sep 8, 2022
2011eric
force-pushed
the
master
branch
3 times, most recently
from
8476893
to
686d398
Compare
|
I think I can pack the code into a function, since the code of fmin and the one of fmax is similar. |
You can introduce some macros as what SoftFP does. |
|
Fix the conflicts caused by recent directory structure changes. |
jserv
reviewed
Sep 11, 2022
Passed 2 more test in riscv-arch-test.
Supports of fmin and fmax is complete.
In IEEE 754-201x, fmin(x,y)/fmax(x,y) is defined as:
- min(x,y)/max(x,y) if both x and y are numbers
- if one is NAN and another is a number, return the number
- if both are NAN, return NAN
This operation raises invalid_operation when receiving SNAN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed 2 more tests in riscv-arch-test.
Support of fmin and fmax is complete.