Switch to PortAudio #76
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should explain the motivation and benefit for the migration of PortAudio. |
Cuda-Chen
force-pushed
the
switch-to-portaudio
branch
3 times, most recently
from
fd58de0 to
0d81990
Compare
Code Review Agent Run Status
|
4 similar comments
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Cuda-Chen
force-pushed
the
switch-to-portaudio
branch
from
6d42303 to
6e00d27
Compare
|
Build failure: |
Thanks for the reminder! |
Cuda-Chen
force-pushed
the
switch-to-portaudio
branch
from
f26f174 to
e331ed7
Compare
jserv
reviewed
Mar 1, 2025
Makefile
Outdated
| git submodule update --init portaudio | ||
| $(PORTAUDIOLIB): portaudio/Makefile | ||
| @cd $(dir $<) && ./configure | ||
| @cd $(dir $<) && $(MAKE) |
There was a problem hiding this comment.
Replace with $(MAKE) -C $(dir $<).
There was a problem hiding this comment.
Hi @jserv ,
As the $(MAKE) -C $(dir $<) have problems with Automake project, so I use a solution of @cd $(dir $<) with the help of LLM.
However, there might be some solutions exist. I will try to figure out.
Cuda-Chen
force-pushed
the
switch-to-portaudio
branch
from
e331ed7 to
e7184f0
Compare
jserv
reviewed
Mar 1, 2025
| goto early_continue; \ | ||
| } \ | ||
| \ | ||
| if (WRITE) { \ |
There was a problem hiding this comment.
Hi @jserv ,
As I don't find any IIF macro in semu repo, the IIF macro you mean is the Linux Kernel networking code for extracting the index of the network interface?
There was a problem hiding this comment.
There was a problem hiding this comment.
Hi @jserv ,
Thanks for the hint! I will take as a reference.
There was a problem hiding this comment.
Eventually, the semu project will be merged into rv32emu, meaning that you can utilize the existing helper macros from rv32emu.
Switch to PortAudio for cross-platform and cross backend compatibility. Yet, there are two known limitations for current sound playback implementation: 1. The last period of sound is lost. 2. You cannot play sound twice or the device will crash thus whole system crashes.
Cuda-Chen
force-pushed
the
switch-to-portaudio
branch
from
e7184f0 to
a73d91d
Compare
jserv
reviewed
Mar 1, 2025
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to PortAudio for cross-platform and cross backend compatibility.
Yet, there are two known limitations for current sound playback implementation:
whole system crashes.
Summary by Bito
This pull request integrates PortAudio to enhance cross-platform audio playback, replacing the previous CNFA submodule. It updates the Makefile for better build configurations, addresses issues like sound loss and system crashes, and improves PCM stream handling and compatibility, while also updating documentation.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2