Fix self-hosting compilation errors #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves critical issues preventing shecc from compiling itself, enabling successful multi-stage bootstrapping. 1. Format string error in src/ssa.c:1138 - changed %s to %d for integer subscript field 2. Added null checks for func->bbs throughout codebase to handle function declarations without bodies, preventing segfaults in SSA and optimization passes 3. Split global variable continuation declarations that shecc doesn't support (e.g., "int a, b;" must be "int a; int b;")
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
The RISC-V target was experiencing segmentation faults during stage2 compilation when stdin was redirected. The root cause was insufficient buffer size for the SOURCE buffer when compiling large programs like shecc itself. The total size of all included source files for RISC-V was approaching the 512KB limit (MAX_SOURCE), and with stdin redirection adding overhead, this caused buffer overflow and segmentation faults. Increased MAX_SOURCE from 524288 (512KB) to 1048576 (1MB) to provide adequate buffer space for self-hosting compilation on all architectures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves critical issues preventing shecc from compiling itself, enabling successful multi-stage bootstrapping.
Summary by cubic
Fixes self-hosting crashes and build failures so shecc can compile itself and complete multi-stage bootstrapping. Stabilizes all compiler passes when encountering function declarations without bodies.