Pass extra session info to subscription callbacks that requested so #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For some niche use cases, during the execution of a subscription callback, it is useful to have access to certain session information (e.g., username and NETCONF session ID that triggered the callback, etc.) * Add "extra_info" argument to all "SysrepoSession.subscribe_xxx" methods (with a default value of False) to indicate the desire to receive extra keyword arguments during the callback call * Pass "netconf_id" (int) and "user" (str) keyword arguments to all callbacks which were subscribed with "extra_info=True" * Extend unit tests to include and cover this new feature
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
- Coverage 66.66% 66.03% -0.64%
==========================================
Files 8 8
Lines 924 945 +21
==========================================
+ Hits 616 624 +8
- Misses 308 321 +13
Continue to review full report at Codecov.
|
nicolasmorini
commented
Jan 15, 2022
|
Hi @rjarry! Is it possible to have an official release containing this change? If there is any change/test required, let me know and I can help to get it done. Regards! |
|
There you go https://pypi.org/project/sysrepo/0.7.0/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some niche use cases, during the execution of a subscription callback,
it is useful to have access to certain session information (e.g., username
and NETCONF session ID that triggered the callback, etc.)
Add "extra_info" argument to all "SysrepoSession.subscribe_xxx" methods
(with a default value of False) to indicate the desire to receive extra
keyword arguments during the callback call
Pass "netconf_id" (int) and "user" (str) keyword arguments to all callbacks
which were subscribed with "extra_info=True"
Extend unit tests to include and cover this new feature