Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searcher dialog help is not opened with '?' when multiple selection #781 #782

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

carlosra85
Copy link
Collaborator

Fix Searcher dialog help is not opened with '?' when multiple selection #781

Tested manually in showcase and in external app as a library

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly (README.md for each UI component)
  • I have added tests to cover my changes (at least 1 spec for each UI component with the same coverage as the master branch)
  • All new and existing tests passed
  • A new branch needs to be created from master to evolve previous versions
  • Increase version in package.json following Semantic Versioning
  • All UI components must be added into the showcase (at least 1 component with the default settings)
  • Add the issue into the right project with the proper status (In progress)

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0447332) 55.13% compared to head (89be681) 55.10%.

Files Patch % Lines
...ts/src/lib/searcher/abstract-searcher.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
- Coverage   55.13%   55.10%   -0.04%     
==========================================
  Files         128      128              
  Lines        3526     3528       +2     
  Branches      615      616       +1     
==========================================
  Hits         1944     1944              
- Misses       1479     1481       +2     
  Partials      103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlosra85 carlosra85 merged commit 3efb8f4 into master Dec 13, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants