Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call of math.div #895

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Fix call of math.div #895

merged 3 commits into from
Jul 24, 2024

Conversation

fjaguado
Copy link
Contributor

@fjaguado fjaguado commented Jul 24, 2024

PR Details

Fix some math.div calls

Description

Problem on compiling Sass files on other projects importing this library

Related Issue

#894

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly (README.md for each UI component)
  • I have added tests to cover my changes (at least 1 spec for each UI component with the same coverage as the master branch)
  • All new and existing tests passed
  • A new branch needs to be created from master to evolve previous versions
  • Increase version in package.json following Semantic Versioning
  • All UI components must be added into the showcase (at least 1 component with the default settings)
  • Add the issue into the right project with the proper status (In progress)

@fjaguado fjaguado added the bug label Jul 24, 2024
@fjaguado fjaguado self-assigned this Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.81%. Comparing base (b6cba23) to head (2ecb2cb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #895   +/-   ##
=======================================
  Coverage   57.81%   57.81%           
=======================================
  Files         132      132           
  Lines        3741     3741           
  Branches      659      659           
=======================================
  Hits         2163     2163           
+ Misses       1469     1468    -1     
- Partials      109      110    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fjaguado fjaguado merged commit 1911372 into master Jul 24, 2024
6 checks passed
@fjaguado fjaguado deleted the feature-894 branch July 24, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants