Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc/intel/tgl: Fix GPIO mapping for TGL-H #73

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

crawfxrd
Copy link
Member

Update GPIOs based on changes to Linux kernel.

Might fix system76/firmware-open#226

Ref: torvalds/linux@2f658f7a395

Update GPIOs based on changes to Linux kernel.

Ref: torvalds/linux@2f658f7a395

Change-Id: I6c23c16caf4afd456d0aa6e3714b1ecc2919ab16
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd crawfxrd requested review from a team August 20, 2021 17:35
@jackpot51
Copy link
Member

Do you also have the kernel patch ready?

@crawfxrd
Copy link
Member Author

crawfxrd commented Aug 20, 2021

5.11: pop-os/linux#64
5.13: pop-os/linux#63

@jacobgkau
Copy link
Member

This does get the touchpad working in Windows; however, it breaks the touchpad in Linux until pop-os/linux#64 is applied. However, applying pop-os/linux#64 without this firmware update also breaks the touchpad. This isn't going to work; we can't be sure people will update their packages and their firmware at the same time (and even if they try, they'll have to do one before the other.)

We need at least one of these to be applyable without the other so we can release one first and give people time to update. It seems like it would be ideal for the kernel to work with older or newer firmware; that way, we can release the kernel update and build new iso/recovery images before releasing the firmware update.

@jackpot51
Copy link
Member

We have a potential solution we will apply in pop-os/linux.

@jackpot51 jackpot51 merged commit 0607f7e into system76 Sep 14, 2021
@jackpot51 jackpot51 deleted the tglh-comms branch September 14, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gaze16: touchpad not working in Windows
3 participants