oryp11,serw13,bonw15: Fix Rsense values #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other RPL boards need to be updated as well. |
crawfxrd
changed the title
PRS1 is 5, but it is in series with PRS3, which is also 5. PRS1 by itself is only connected to ACP/ACN. Ref: oryp11 schematics, AC In Charger (Sheet 59) Ref: serw13 schematics, AC_In, Charger (Sheet 70) Signed-off-by: Tim Crawford <tcrawford@system76.com>
|
Also need to figure out wtf is going on with bonw15. PRS1 and PRS2 are 0.005 Ohms, but are in parallel. |
crawfxrd
changed the title
PRS3 is 0.005 Ohms. However, I am unsure about this change because PRS1 and PRS2 are also both 0.005 Ohms, but are in *parallel*. Ref: bonw15 schematics, Charger (Sheet 70) Signed-off-by: Tim Crawford <tcrawford@system76.com>
leviport
approved these changes
Jul 6, 2023
jackpot51
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On oryp11 and serw13: PRS1 is 5, but it is in series with PRS3, which is also 5. PRS1 by itself is only connected to ACP/ACN.
On bonw15: Battery Rsense is 0.005 Ohms. However, PRS1 and PRS2 are also both 0.005 Ohms, but are in parallel.
Ref: oryp11 schematics, AC In Charger (Sheet 59)
Ref: serw13 schematics, AC_In, Charger (Sheet 70)
Ref: bonw15 schematics, Charger (Sheet 70)