Reset KBC on CPU reset #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function can be called after EC init to put the KBC into a known working state. Signed-off-by: Tim Crawford <tcrawford@system76.com>
Ensure the keyboard controller is not left locked/disabled. Signed-off-by: Tim Crawford <tcrawford@system76.com>
leviport
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
I believe this is working. I don't know a reliable way to reproduce the unresponsive keyboard for certain, but I was seeing it frequently on bonw15. Previously, unplugging and re-plugging the AC adapter while the machine was off would make the keyboard work again.
With this update, I did not see the keyboard become unresponsive in the firmware menu at all.
jackpot51
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix KBC being locked/disabled on boot.
TODO: Determine what is actually disabling it