Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kbscan: Increase debounce time from 5ms to 10ms #405

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented Sep 7, 2023

Some users are reporting that a debounce time of 5ms is not enough to prevent keys from registering twice. Split the difference between the old and the new debounce times and set it to 10ms.

Ref: system76/firmware-open#471

Some users are reporting that a debounce time of 5ms is not enough to
prevent keys from registering twice. Split the difference between the
old and the new debounce times and set it to 10ms.

Ref: system76/firmware-open#471
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd crawfxrd requested review from jackpot51 and a team September 7, 2023 15:35
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two darp8's set up side-by-side, one with 5ms and the other with 10ms, and I can't tell a difference, even typing ~115wpm on typing tests. I don't think my typing style is one that is affected by the 5ms debounce. It seems to be working though, so I approve.

@jackpot51 jackpot51 merged commit 181d4c5 into master Sep 7, 2023
41 checks passed
@jackpot51 jackpot51 deleted the debounce-time branch September 7, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants