Allow specifying OpenPGP implementation to use for signing #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-k
force-pushed
the
wiktor/teach-mkosi-sop
branch
2 times, most recently
from
88fd737 to
2f5e5db
Compare
wiktor-k
force-pushed
the
wiktor/teach-mkosi-sop
branch
from
2f5e5db to
c57403e
Compare
|
I'm curious about hardware tokens. Will those be supported with a unified CLI interface as well? |
behrmann
reviewed
Oct 2, 2024
wiktor-k
force-pushed
the
wiktor/teach-mkosi-sop
branch
from
c57403e to
3b88281
Compare
Yes, I actually tested that with my Yubikey and found a couple of issues I fixed. This, of course, depends on the underlying SOP implementation that's used. |
|
Okay folks, thanks for the great feedback! I need to install the type-checking tools locally not to spam the CI. I'll be back with the adjustments (all valid points! 🙇 ) |
wiktor-k
force-pushed
the
wiktor/teach-mkosi-sop
branch
from
3b88281 to
43a85d8
Compare
wiktor-k
force-pushed
the
wiktor/teach-mkosi-sop
branch
2 times, most recently
from
5028264 to
49e8075
Compare
wiktor-k
force-pushed
the
wiktor/teach-mkosi-sop
branch
from
49e8075 to
84a0f98
Compare
behrmann
reviewed
Oct 3, 2024
wiktor-k
force-pushed
the
wiktor/teach-mkosi-sop
branch
5 times, most recently
from
7de844c to
efc0a77
Compare
DaanDeMeyer
reviewed
Oct 4, 2024
wiktor-k
force-pushed
the
wiktor/teach-mkosi-sop
branch
2 times, most recently
from
aa13165 to
efc0a77
Compare
DaanDeMeyer
reviewed
Oct 7, 2024
wiktor-k
force-pushed
the
wiktor/teach-mkosi-sop
branch
3 times, most recently
from
9231cb6 to
a949723
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
wiktor-k
force-pushed
the
wiktor/teach-mkosi-sop
branch
3 times, most recently
from
12f445e to
396ccdb
Compare
|
Okay, I've adjusted the PR and included manpage changes. The CI failures don't look to be related (please correct me if I'm wrong). Thanks! 👋 |
DaanDeMeyer
requested changes
Oct 23, 2024
wiktor-k
force-pushed
the
wiktor/teach-mkosi-sop
branch
from
396ccdb to
331132d
Compare
behrmann
reviewed
Oct 23, 2024
wiktor-k
force-pushed
the
wiktor/teach-mkosi-sop
branch
3 times, most recently
from
3cc7fd4 to
d8201f8
Compare
behrmann
approved these changes
Oct 26, 2024
behrmann
added
good-to-merge/with-minor-suggestions
and removed
reviewed/needs-rework
labels
wiktor-k
force-pushed
the
wiktor/teach-mkosi-sop
branch
from
d8201f8 to
8666c94
Compare
behrmann
added
good-to-merge/waiting-for-ci
and removed
good-to-merge/with-minor-suggestions
labels
Phew, thanks for your time! Nits resolved 😅 |
DaanDeMeyer
reviewed
Oct 28, 2024
wiktor-k
force-pushed
the
wiktor/teach-mkosi-sop
branch
from
8666c94 to
5a1e85a
Compare
DaanDeMeyer
requested changes
Oct 28, 2024
wiktor-k
force-pushed
the
wiktor/teach-mkosi-sop
branch
2 times, most recently
from
46ccdad to
94ac780
Compare
DaanDeMeyer
requested changes
Oct 28, 2024
wiktor-k
force-pushed
the
wiktor/teach-mkosi-sop
branch
from
94ac780 to
c315931
Compare
DaanDeMeyer
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
I'm pushing a first preview of SOP signing for SHA256SUMs. I've tested that locally and also added tests for rsop and old gpg (just in case) and will begin to refactor this a bit. Since I'm new to both mkosi and Python I think it's good to get feedback earlier in the process if something looks particularly wrong here.
Note that I've tried to make it as minimal as possible with no nice-to-have adjustments mentioned in #3042.
Fixes: #3042
CC: @dvzrv