Define our own config for PE addons and UKI profiles #3106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is on top of #3103 |
DaanDeMeyer
force-pushed
the
simple-config
branch
3 times, most recently
from
a0efc1b
to
6bb64ec
Compare
behrmann
reviewed
Oct 7, 2024
ukify's config parser uses python's configparser module and as such suffers from all its issues just like we used to in mkosi. Having ukify parse the config file also means that we have to make sure any paths configured in the profile are available in the sandbox. Instead, let's define our own configs for the PE addons and UKI profiles so we get to take advantage of our own config file parser and have full knowledge of all the configured settings so we can mount extra stuff into the sandbox if needed. It also gets rid of the hack where we parse ukify's config file to figure out the command line.
DaanDeMeyer
force-pushed
the
simple-config
branch
from
6bb64ec
to
47da884
Compare
behrmann
added
the
needs-news-entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ukify's config parser uses python's configparser module and as such
suffers from all its issues just like we used to in mkosi. Having ukify
parse the config file also means that we have to make sure any paths
configured in the profile are available in the sandbox.
Instead, let's define our own configs for the PE addons and UKI profiles
so we get to take advantage of our own config file parser and have full
knowledge of all the configured settings so we can mount extra stuff into
the sandbox if needed.
It also gets rid of the hack where we parse ukify's config file to figure
out the command line.
cc @NekkoDroid