-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more granular control on which artifacts are output #3131
Conversation
52ce4eb
to
e399187
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the refactor in the first commit (sans the style nits), but I'm a bit -0 on the second commit, since it breaks backwards compatibility and I'm not quite sure I understand why the superfluous artifacts cannot be deleted with a postoutput script, but I don't have too strong feelings there.
The backwards compat could probably be kept by making ArtifactsOutput
a enum.Flag
instead of a StrEnum
, which would then probably look something like
class ArtifactOutput(enum.Flag):
false = 0
uki = 1
kernel = 2
initrd = 4
partitions = 8
true = 7
4aa845e
to
4fcb7f8
Compare
still looking into using |
4fcb7f8
to
f1b93df
Compare
I am unable to figure out how to serialize the value to JSON and actually make it assign the value when returning from the parse function. When setting any value it still keeps resulting in the default ( |
6fc69f7
to
e0dbde1
Compare
49b301c
to
caadcca
Compare
the JSON problem is "solved" (happy for any recommendation that makes it easier to understand than the raw flag number).
|
d5abbf6
to
be3875a
Compare
Some CI fails due to dnf, but others seem to not be able to
|
I'm travelling this weekend and forgot my notebook, so will only be able to look at this again on Monday, sorry.
|
56bdc34
to
570ac0f
Compare
570ac0f
to
94c1431
Compare
Needing to use |
385a2d6
to
c51f816
Compare
A follow-up commit will introduce the ability to disable copying these to the output directory, so refactor all the logic so that they are contained within their respectiv functions.
8545f80
to
239ff25
Compare
This allows more precision on which artifacts are actually split out of the image and placed into the output directory. Defaults to splitting the UKI, vmlinuz and the initrd out.
239ff25
to
ed059dc
Compare
This PR repurposes
SplitArtifacts=
to be able to specify multiple artifact types that should be split out of the image. By specifying one or more ofuki
,kernel
,initrd
andpartitions
the respective components are extracted from the image. The truthy and falsy values still map to the equivalent of the old values to preserve backwards compatibility.