Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entropy and memory graph heights explode #46

Closed
eMPee584 opened this issue Feb 21, 2021 · 0 comments · Fixed by #50
Closed

Entropy and memory graph heights explode #46

eMPee584 opened this issue Feb 21, 2021 · 0 comments · Fixed by #50

Comments

@eMPee584
Copy link

Something is not quite right with this graph:
bootchart-20210221-1726.svg.gz

Had no luck getting a sane result.. with systemd-bootchart 233-2 in a debian VM and

PlotMemoryUsage=yes
PlotEntropyGraph=yes
eMPee584 added a commit to fsfw-dresden/usb-live-linux that referenced this issue Apr 4, 2021
@eMPee584
↓ systemd-bootchart sample rate & turn off borken entropy / mem graph
df9ebc2 
pending systemd/systemd-bootchart#46
amurzeau added a commit to amurzeau/systemd-bootchart that referenced this issue Aug 23, 2023
@amurzeau
fix PSS graph on recent kernels
369f1cb 
It seems the smaps file layout in /proc changed in some kernel version.
This commit fix it by:
- Using smaps_rollup instead of smaps to avoid having to loop over all
  entries (smaps_rollup being a summary of smaps)
- Searching "Pss:" instead of using hardcoded offsets (which will
  probably go wrong again in the future).

Fixes: systemd#46
@amurzeau amurzeau mentioned this issue Aug 23, 2023
Merged
amurzeau added a commit to amurzeau/systemd-bootchart that referenced this issue Aug 28, 2023
@amurzeau
fix PSS graph on recent kernels
4947baf 
It seems the smaps file layout in /proc changed in some kernel version.
This commit fix it by:
- Using smaps_rollup (available since kernel 4.14) instead of smaps to
  avoid having to loop over all entries (smaps_rollup being a summary
  of smaps).

- If smaps_rollup is not available (kernel < 4.14), use smaps instead as
  before and sum all PSS lines.

- Searching "Pss:" instead of using hardcoded offsets (which will
  probably go wrong again in the future).

Fixes: systemd#46
@bluca bluca closed this as completed in #50 Aug 28, 2023
bluca pushed a commit that referenced this issue Aug 28, 2023
@amurzeau @bluca
fix PSS graph on recent kernels
b8c1c50 
It seems the smaps file layout in /proc changed in some kernel version.
This commit fix it by:
- Using smaps_rollup (available since kernel 4.14) instead of smaps to
  avoid having to loop over all entries (smaps_rollup being a summary
  of smaps).

- If smaps_rollup is not available (kernel < 4.14), use smaps instead as
  before and sum all PSS lines.

- Searching "Pss:" instead of using hardcoded offsets (which will
  probably go wrong again in the future).

Fixes: #46
kraj pushed a commit to kraj/systemd-bootchart that referenced this issue May 21, 2024
@amurzeau @kraj
fix PSS graph on recent kernels
4403ebc 
It seems the smaps file layout in /proc changed in some kernel version.
This commit fix it by:
- Using smaps_rollup (available since kernel 4.14) instead of smaps to
  avoid having to loop over all entries (smaps_rollup being a summary
  of smaps).

- If smaps_rollup is not available (kernel < 4.14), use smaps instead as
  before and sum all PSS lines.

- Searching "Pss:" instead of using hardcoded offsets (which will
  probably go wrong again in the future).

Fixes: systemd#46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix PSS graph on recent kernels amurzeau/systemd-bootchart
1 participant
@eMPee584