Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwdb: CH Pro Pedals not classified correctly due to no buttons #22184

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

twhitehead
Copy link
Contributor

@twhitehead twhitehead commented Jan 20, 2022

Automatic classification puts it as an accelerometer due to having no buttons.

This is actually an old issue @poettering said to CC @whot on, but then I forgot to follow up on as I had a local workaround.

https://bugs.freedesktop.org/show_bug.cgi?id=81889

@github-actions github-actions bot added the hwdb label Jan 20, 2022
@whot whot added the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Jan 20, 2022
hwdb.d/60-input-id.hwdb Outdated Show resolved Hide resolved
hwdb.d/60-input-id.hwdb Outdated Show resolved Hide resolved
@yuwata yuwata added ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR and removed good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed labels Jan 20, 2022
@yuwata yuwata added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR labels Jan 20, 2022
@yuwata
Copy link
Member

yuwata commented Jan 20, 2022

Force-pushed fixed version. And setting the green label again.

@yuwata yuwata merged commit 230ed4c into systemd:main Jan 20, 2022
@twhitehead
Copy link
Contributor Author

Much appreciated. Thanks! 👍

bluca pushed a commit that referenced this pull request Feb 16, 2024
CH Pedals are incorrectly reported as an accelerometer [1], because they
have no button.  This is fixed by a rule in 60-input-id.hwdb [2], but
the rule checks id/version="0100", while my pedals report id/version="0111".

So there are several versions of the pedals, presumably all affected
by the bug. Remove the version check in the rule to fix them all.

[1] https://bugs.freedesktop.org/show_bug.cgi?id=81889
[2] commit: 230ed4c (hwdb: CH Pro Pedals not classified correctly due to no buttons, 2022-01-19)
    PR: #22184
ayhamthemayhem pushed a commit to neighbourhoodie/nh-systemd that referenced this pull request Mar 25, 2024
CH Pedals are incorrectly reported as an accelerometer [1], because they
have no button.  This is fixed by a rule in 60-input-id.hwdb [2], but
the rule checks id/version="0100", while my pedals report id/version="0111".

So there are several versions of the pedals, presumably all affected
by the bug. Remove the version check in the rule to fix them all.

[1] https://bugs.freedesktop.org/show_bug.cgi?id=81889
[2] commit: 230ed4c (hwdb: CH Pro Pedals not classified correctly due to no buttons, 2022-01-19)
    PR: systemd#22184
chunyi-wu pushed a commit to chunyi-wu/systemd that referenced this pull request Apr 3, 2024
CH Pedals are incorrectly reported as an accelerometer [1], because they
have no button.  This is fixed by a rule in 60-input-id.hwdb [2], but
the rule checks id/version="0100", while my pedals report id/version="0111".

So there are several versions of the pedals, presumably all affected
by the bug. Remove the version check in the rule to fix them all.

[1] https://bugs.freedesktop.org/show_bug.cgi?id=81889
[2] commit: 230ed4c (hwdb: CH Pro Pedals not classified correctly due to no buttons, 2022-01-19)
    PR: systemd#22184
dtardon pushed a commit to dtardon/systemd-rhel9 that referenced this pull request Aug 6, 2024
CH Pedals are incorrectly reported as an accelerometer [1], because they
have no button.  This is fixed by a rule in 60-input-id.hwdb [2], but
the rule checks id/version="0100", while my pedals report id/version="0111".

So there are several versions of the pedals, presumably all affected
by the bug. Remove the version check in the rule to fix them all.

[1] https://bugs.freedesktop.org/show_bug.cgi?id=81889
[2] commit: 230ed4c (hwdb: CH Pro Pedals not classified correctly due to no buttons, 2022-01-19)
    PR: systemd/systemd#22184

(cherry picked from commit bd083fc)

Related: RHEL-5950
jamacku pushed a commit to redhat-plumbers/systemd-rhel9 that referenced this pull request Aug 9, 2024
CH Pedals are incorrectly reported as an accelerometer [1], because they
have no button.  This is fixed by a rule in 60-input-id.hwdb [2], but
the rule checks id/version="0100", while my pedals report id/version="0111".

So there are several versions of the pedals, presumably all affected
by the bug. Remove the version check in the rule to fix them all.

[1] https://bugs.freedesktop.org/show_bug.cgi?id=81889
[2] commit: 230ed4c (hwdb: CH Pro Pedals not classified correctly due to no buttons, 2022-01-19)
    PR: systemd/systemd#22184

(cherry picked from commit bd083fc)

Related: RHEL-5950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed hwdb
Development

Successfully merging this pull request may close these issues.

3 participants