-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hwdb: CH Pro Pedals not classified correctly due to no buttons #22184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whot
added
the
good-to-merge/waiting-for-ci 👍
PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed
label
Jan 20, 2022
yuwata
requested changes
Jan 20, 2022
yuwata
added
ci-fails/needs-rework 🔥
Please rework this, the CI noticed an issue with the PR
and removed
good-to-merge/waiting-for-ci 👍
PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed
labels
Jan 20, 2022
yuwata
added
good-to-merge/waiting-for-ci 👍
PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed
and removed
ci-fails/needs-rework 🔥
Please rework this, the CI noticed an issue with the PR
labels
Jan 20, 2022
Force-pushed fixed version. And setting the green label again. |
yuwata
approved these changes
Jan 20, 2022
Much appreciated. Thanks! 👍 |
bluca
pushed a commit
that referenced
this pull request
Feb 16, 2024
CH Pedals are incorrectly reported as an accelerometer [1], because they have no button. This is fixed by a rule in 60-input-id.hwdb [2], but the rule checks id/version="0100", while my pedals report id/version="0111". So there are several versions of the pedals, presumably all affected by the bug. Remove the version check in the rule to fix them all. [1] https://bugs.freedesktop.org/show_bug.cgi?id=81889 [2] commit: 230ed4c (hwdb: CH Pro Pedals not classified correctly due to no buttons, 2022-01-19) PR: #22184
ayhamthemayhem
pushed a commit
to neighbourhoodie/nh-systemd
that referenced
this pull request
Mar 25, 2024
CH Pedals are incorrectly reported as an accelerometer [1], because they have no button. This is fixed by a rule in 60-input-id.hwdb [2], but the rule checks id/version="0100", while my pedals report id/version="0111". So there are several versions of the pedals, presumably all affected by the bug. Remove the version check in the rule to fix them all. [1] https://bugs.freedesktop.org/show_bug.cgi?id=81889 [2] commit: 230ed4c (hwdb: CH Pro Pedals not classified correctly due to no buttons, 2022-01-19) PR: systemd#22184
chunyi-wu
pushed a commit
to chunyi-wu/systemd
that referenced
this pull request
Apr 3, 2024
CH Pedals are incorrectly reported as an accelerometer [1], because they have no button. This is fixed by a rule in 60-input-id.hwdb [2], but the rule checks id/version="0100", while my pedals report id/version="0111". So there are several versions of the pedals, presumably all affected by the bug. Remove the version check in the rule to fix them all. [1] https://bugs.freedesktop.org/show_bug.cgi?id=81889 [2] commit: 230ed4c (hwdb: CH Pro Pedals not classified correctly due to no buttons, 2022-01-19) PR: systemd#22184
dtardon
pushed a commit
to dtardon/systemd-rhel9
that referenced
this pull request
Aug 6, 2024
CH Pedals are incorrectly reported as an accelerometer [1], because they have no button. This is fixed by a rule in 60-input-id.hwdb [2], but the rule checks id/version="0100", while my pedals report id/version="0111". So there are several versions of the pedals, presumably all affected by the bug. Remove the version check in the rule to fix them all. [1] https://bugs.freedesktop.org/show_bug.cgi?id=81889 [2] commit: 230ed4c (hwdb: CH Pro Pedals not classified correctly due to no buttons, 2022-01-19) PR: systemd/systemd#22184 (cherry picked from commit bd083fc) Related: RHEL-5950
jamacku
pushed a commit
to redhat-plumbers/systemd-rhel9
that referenced
this pull request
Aug 9, 2024
CH Pedals are incorrectly reported as an accelerometer [1], because they have no button. This is fixed by a rule in 60-input-id.hwdb [2], but the rule checks id/version="0100", while my pedals report id/version="0111". So there are several versions of the pedals, presumably all affected by the bug. Remove the version check in the rule to fix them all. [1] https://bugs.freedesktop.org/show_bug.cgi?id=81889 [2] commit: 230ed4c (hwdb: CH Pro Pedals not classified correctly due to no buttons, 2022-01-19) PR: systemd/systemd#22184 (cherry picked from commit bd083fc) Related: RHEL-5950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good-to-merge/waiting-for-ci 👍
PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed
hwdb
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic classification puts it as an accelerometer due to having no buttons.
This is actually an old issue @poettering said to CC @whot on, but then I forgot to follow up on as I had a local workaround.
https://bugs.freedesktop.org/show_bug.cgi?id=81889