mkfs-util: propagate SOURCE_DATE_EPOCH to mcopy #29000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluca
reviewed
Aug 28, 2023
poettering
reviewed
Aug 29, 2023
poettering
reviewed
Aug 29, 2023
poettering
reviewed
Aug 29, 2023
poettering
added
the
reviewed/needs-rework 🔨
Co-authored-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
|
lgtm. any reason you still set this to draft? |
I didn't have time to check if all reproducibility issues are resolved when it comes to FAT. |
github-actions
bot
added
please-review
DaanDeMeyer
approved these changes
Aug 29, 2023
DaanDeMeyer
added
good-to-merge/waiting-for-ci 👍
bluca
approved these changes
Aug 29, 2023
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If set, mcopy will respect
SOURCE_DATE_EPOCHand deterministically sets ctime, mtime and atime when creating folders / files in FAT partitions.Since mcopy is invoked with
execve, SOURCE_DATE_EPOCH has to be propagated explicitly.