Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker dynamic build #567

Merged
merged 2 commits into from
Nov 4, 2023

Conversation

Booligoosh
Copy link
Contributor

Fixes the dynamically linked Docker image by installing the required libs on the final Docker image as well as the build Docker image. Now that it's not statically linked, they need to be present on the final Docker image as well, so that the Tilemaker executable can access them.

Note that building it like this with dynamic linking and the dependencies installed on the image increases the size of the image to 444MB, undoing some of the work from #363.

@Booligoosh
Copy link
Contributor Author

Booligoosh commented Nov 4, 2023

Note that the "Generate mbtiles" check is still failing, because the GitHub Action is using the master image from Docker.

This probably ties into a larger conversation around tagging, versioning, and release management. Ideally, the CI would only run when new version tags are pushed, and then upload the Docker image with the correct version tag.

Then the GitHub action can reference the docker image tagged with the same version as the action itself - so if someone's workflow file references systemed/tilemaker@v2.0.0 then it'll use the image docker://ghcr.io/systemed/tilemaker:v2.0.0 rather than docker://ghcr.io/systemed/tilemaker:master.

But yeah, this docker image worked when I tested it locally, so the pipeline should hopefully pass once merged in.

@Booligoosh Booligoosh marked this pull request as draft November 4, 2023 06:11
@Booligoosh Booligoosh marked this pull request as ready for review November 4, 2023 06:30
@systemed systemed merged commit 5153a60 into systemed:master Nov 4, 2023
4 of 5 checks passed
@systemed
Copy link
Owner

systemed commented Nov 4, 2023

Superb - thank you. I've merged it and forced a re-run (so it picks up the new image) and it's happily working.

Yes, that sounds like a good direction for the future for the image management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants