Code

AttributeStore memory tweaks#583

Code

Merged

systemed merged 34 commits intosystemed:refactor_geometriessystemed/tilemaker:refactor_geometriesfrom cldellow:pr-499-perf-tweakscldellow/tilemaker:pr-499-perf-tweaksCopy head branch name to clipboardNov 19, 2023

+763-186

Commits

Commits on Nov 16, 2023

• make AttributeStore::get const

  Show description for 697b1cf
  cldellow

  committed
  697b1cf

• use a string pool for AttributeSet keys

  Show description for 066b817
  cldellow

  committed
  066b817

• lock-free reads for keys, vector for pairs

  Show description for 22e60b9
  cldellow

  committed
  22e60b9

• Have a "hot" shard for popular pairs

  Show description for a80dd09
  cldellow

  committed
  a80dd09

• treat 0 as a sentinel

  cldellow

  committed
  66adb1d

• de-dupe all AttributePairs

  Show description for 859e415
  cldellow

  committed
  859e415

• store pointers in pairMaps, optimize debug spew

  Show description for 73b8769
  cldellow

  committed
  73b8769

• use boost::container::flat_map over std::map

  Show description for 1f08a81
  cldellow

  committed
  1f08a81

• don't memoize hash function

  Show description for 39f1c43
  cldellow

  committed
  39f1c43

• output_object: avoid Tile_Value temporaries

  Show description for 2641612
  cldellow

  committed
  2641612

• defer creating Tile_Value

  Show description for 2e66005
  cldellow

  committed
  2e66005

• adjust headers, remove unneeded rng

  cldellow

  committed
  60c36f3

• any integer 0 <= 25 is eligible for hot pool

  Show description for f06c2ac
  cldellow

  committed
  f06c2ac

• Use a small vector optimization for pair indexes

  Show description for f8060f5
  cldellow

  committed
  f8060f5

• simplify AttributeKeyStore

  cldellow

  committed
  13f72ae

Commits on Nov 17, 2023

• use camelCase

  cldellow

  committed
  1f43dbc

• re-write to avoid static lifetime

  Show description for 23b6a90
  cldellow

  committed
  23b6a90

• reduce lock contention

  cldellow

  committed
  a4b55d3

• Improve TileCoordinates hash function

  Show description for 7570737
  cldellow

  committed
  7570737

• d'oh, avoid looking up the key name needlessly

  cldellow

  committed
  8ddf6de

• change AttributeXyz(...) to be last-written wins

  Show description for f9a1931
  cldellow

  committed
  f9a1931

• remove misleading comment

  cldellow

  committed
  f9ccf3c

• include deque

  cldellow

  committed
  6ba6db2

• include map

  cldellow

  committed
  2f61bc9

• return vector, not set

  Show description for 3e6df15
  cldellow

  committed
  3e6df15

• avoid GNU-specific initializer

  Show description for 9436324
  cldellow

  committed
  9436324

• Revert "Improve TileCoordinates hash function"

  Show description for 4e5d2ef
  cldellow

  committed
  4e5d2ef

Commits on Nov 18, 2023

• remove dead code

  cldellow

  committed
  063bc3c

• avoid copying AttributePairs

  Show description for 6f31fc3
  cldellow

  committed
  6f31fc3

• OutputObjects - greatly reduce need for locks

  Show description for 557a077
  cldellow

  committed
  557a077

• AttributeKeyStore: use a TLS cache

  Show description for 75ff493
  cldellow

  committed
  75ff493

• AttributePairStore: reduce lock contention

  cldellow

  committed
  de9e4d6

• ensure atomics are initialized

  Show description for a285c93
  cldellow

  committed
  a285c93

• don't store duplicate way geometries

  Show description for 008ea72
  cldellow

  committed
  008ea72