compile streamvbyte as C, not C++ #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In systemed#590, I compiled these as C++ files. This was wrong, as they're meant to be compiled as C files. Depending on your compiler, you would hit errors to do with `restrict` or `__restrict__` references. This reverts the streamvbyte code to be a more vanilla copy of upstream, and updates the `Makefile` and `CMakeLists.txt` files to build them as C.
|
Excellent - thank you! (Fine on Intel Mac too, unsurprisingly.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This fixes the ARM Mac build complaints about streamvbyte, one of the things reported at #536.)
In #590, I compiled these as C++ files.
This was wrong, as they're meant to be compiled as C files. Depending on your compiler, you would hit errors to do with
restrictor__restrict__references.This reverts the streamvbyte code to be a more vanilla copy of upstream, and updates the
MakefileandCMakeLists.txtfiles to build them as C.I've tested that this builds on ARM Ubuntu 22 with gcc, and @FunMiles has verified it builds on ARM Mac.