Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR build tweaks #670

Merged
merged 25 commits into from
Feb 10, 2024
Merged

PR build tweaks #670

merged 25 commits into from
Feb 10, 2024

Conversation

cldellow
Copy link
Contributor

@cldellow cldellow commented Feb 4, 2024

This tries to expand the PR builds to catch some of the issues that have cropped up:

  • add Makefile builds, including make test
  • add Apple Silicon runner (released Jan 30, 2024 - see GitHub blog post)
    • Added @systemed's patch that fixes MAC OS issue with types during the make command #664 so the build would pass
    • There's no CMake build on Apple Silicon yet, just a Makefile build. Unlike the Intel Silicon Mac OS image, the ARM image does not have vcpkg pre-installed. I tried to figure out how to install vcpkg myself, but couldn't get it sorted, so I decided it could be a nice-to-have and dealt with in the future.
  • fail build if tilemaker command has non-zero exit code
  • also do a pmtiles build with --store to ensure that mbtiles/pmtiles and lazy/materialized geometries are being smoketested

There's still no verification of the contents of the output files, but even just validating that the command runs with no errors is a start.

@systemed systemed merged commit c630400 into systemed:master Feb 10, 2024
8 checks passed
@systemed
Copy link
Owner

Excellent - I hadn't spotted the Apple Silicon runners. Thank you. I might bundle all of these up into a 3.0.1 before long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAC OS issue with types during the make command Latest version does not work on windows
2 participants