Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export and render building:part #692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

c84c
Copy link

@c84c c84c commented Mar 1, 2024

First of all, thanks for this great project!

With this PR, I add the ability to export and render building:part relations (thanks to Multipolygon relations are supported natively by tilemaker).

For the 3D building render style, credits to @tgdbepe4 and his great style!

Resolve #458.

The result is shown below for 2 monuments in Rome (Italy).

Building Before PR After PR
"name:it": "Castel Sant'Angelo" CastelSantAngelo_before CastelSantAngelo_after
"name:it": "Piazza San Pietro" PiazzaSanPietro_before PiazzaSanPietro_after

@c84c c84c force-pushed the export_building_parts branch 2 times, most recently from b57d7db to b5cebd2 Compare March 1, 2024 12:47
@c84c
Copy link
Author

c84c commented Mar 1, 2024

I change formatting minimizing code changes

@pnorman
Copy link
Contributor

pnorman commented Mar 4, 2024

OpenMapTiles says it just uses building=*, but later on goes to talk about the height of the building or building:part. I assume it's contradicting itself and in practice and the most common implementation includes building:part?

@c84c
Copy link
Author

c84c commented Mar 4, 2024

Exploring implementation they use also building:part to insert buildings in mbtiles.

@c84c c84c force-pushed the export_building_parts branch from b5cebd2 to 7b206a7 Compare May 19, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to display relation data on map
2 participants