Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change interfaces to types for quickinfo #2841

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

sprutton1
Copy link
Contributor

Same as described here, the Typescript system does not extract deep information from interfaces, so if we want the details on the hover/hotkey, we need them to be types.

I have no idea what implications this might have elsewhere, so insight there would be good. Everything seems good in my tests still.

@github-actions github-actions bot added the A-sdf Area: Primary backend API service [Rust] label Oct 10, 2023
Copy link
Contributor

@paulocsanz paulocsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked if this causes a lint breakage for any function? Because variable definition works differently with interfaces and types.

If not, I'm cool with it.

@sprutton1
Copy link
Contributor Author

Have you checked if this causes a lint breakage for any function? Because variable definition works differently with interfaces and types.

If not, I'm cool with it.

I don't see any new linter errors on the existing functions I checked. I haven't checked all of them, but I imagine we'll catch them as @stack72 goes through and fixes them up.

@sprutton1
Copy link
Contributor Author

bors r+

@si-bors-ng
Copy link
Contributor

si-bors-ng bot commented Oct 10, 2023

Build succeeded:

@si-bors-ng si-bors-ng bot merged commit 12187cb into main Oct 10, 2023
8 checks passed
@si-bors-ng si-bors-ng bot deleted the scott/outputtypes branch October 10, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdf Area: Primary backend API service [Rust]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants