Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: to determine what mgmt edges are removed, we need all mgmt edges, not just components & edges in the view #5255

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

jobelenus
Copy link
Contributor

@jobelenus jobelenus commented Jan 15, 2025

Same fix as the one before, but very different
image

Copy link

github-actions bot commented Jan 15, 2025

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@jobelenus jobelenus force-pushed the fix/removed_mgmt_edges_needs_em_all branch from 4887d71 to 4d69996 Compare January 15, 2025 23:36
@jobelenus
Copy link
Contributor Author

@zacharyhamm this code needs a lot of love. I just grabbed helper code from places that used ctx, but we can't use ctx because we're using base_snapshot. Would love to get a sense of the better rust-y way to accomplish this!

@jobelenus jobelenus force-pushed the fix/removed_mgmt_edges_needs_em_all branch 6 times, most recently from 4419b32 to d951dd1 Compare January 17, 2025 18:50
@jobelenus jobelenus enabled auto-merge January 17, 2025 18:50
@jobelenus jobelenus force-pushed the fix/removed_mgmt_edges_needs_em_all branch from d951dd1 to d5045e0 Compare January 17, 2025 18:57
Copy link
Contributor

@zacharyhamm zacharyhamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

@jobelenus jobelenus added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@zacharyhamm
Copy link
Contributor

@jobelenus if this isn't on up to date a rebase might make the tests more reliable

@jobelenus jobelenus force-pushed the fix/removed_mgmt_edges_needs_em_all branch from d5045e0 to 72a58c3 Compare January 17, 2025 21:32
@zacharyhamm zacharyhamm added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@jobelenus jobelenus added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 4b8f5ba Jan 17, 2025
9 checks passed
@jobelenus jobelenus deleted the fix/removed_mgmt_edges_needs_em_all branch January 17, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants