Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: arm rootfs needs an arm linker #5283

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix: arm rootfs needs an arm linker #5283

merged 2 commits into from
Jan 17, 2025

Conversation

sprutton1
Copy link
Contributor

I created this link manually in an arm64 rootfs and things started to work

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ⚠️ 1 packages with OpenSSF Scorecard issues.
See the Details below.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/proper-lockfile ^4.1.2 ⚠️ 2
Details
CheckScoreReason
Dangerous-Workflow⚠️ -1no workflows found
Token-Permissions⚠️ -1No tokens found
Code-Review⚠️ 2Found 6/27 approved changesets -- score normalized to 2
Packaging⚠️ -1packaging workflow not detected
Maintained⚠️ 00 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ -1no dependencies found
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Security-Policy⚠️ 0security policy file not detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Vulnerabilities⚠️ 043 existing vulnerabilities detected

Scanned Files

  • bin/lang-js/package.json

@johnrwatson johnrwatson self-requested a review January 17, 2025 17:51
johnrwatson
johnrwatson previously approved these changes Jan 17, 2025
View reviewed changes
zacharyhamm
zacharyhamm previously approved these changes Jan 17, 2025
View reviewed changes
@sprutton1 sprutton1 added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@sprutton1 sprutton1 added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@sprutton1 sprutton1 added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@sprutton1 sprutton1 added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@sprutton1 sprutton1 added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@sprutton1 sprutton1 added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@sprutton1 sprutton1 added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@sprutton1 sprutton1 added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@sprutton1 sprutton1 added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@sprutton1 sprutton1 added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@sprutton1 sprutton1 added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@sprutton1 sprutton1 added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@sprutton1 sprutton1 added this pull request to the merge queue Jan 17, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Okay, starting a try! I'll update this comment once it's running...\n
🚀 Try running here! 🚀

@sprutton1
Copy link
Contributor Author

/try

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Okay, starting a try! I'll update this comment once it's running...\n
🚀 Try running here! 🚀

@sprutton1
Copy link
Contributor Author

/try

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Okay, starting a try! I'll update this comment once it's running...\n
🚀 Try running here! 🚀

zacharyhamm
zacharyhamm reviewed Jan 17, 2025
View reviewed changes
bin/lang-js/src/function_kinds/management.ts
@@ -44,7 +44,7 @@ export interface ManagementCreate {
}

export interface ManagementOperations {
create?: ManagementCreate,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

zacharyhamm
zacharyhamm reviewed Jan 17, 2025
View reviewed changes
bin/lang-js/src/function.ts
@@ -19,6 +19,7 @@ import { Debugger } from "./debug.ts";
import { transpile } from "jsr:@deno/emit";
import { Debug } from "./debug.ts";
import * as _worker from "./worker.js";
import { bundleCode } from "./transpile.ts";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on here exactly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to go from ts -> js so we can build it out as a function to run in the web worker

zacharyhamm
zacharyhamm reviewed Jan 17, 2025
View reviewed changes
bin/lang-js/src/transpile.ts Outdated

const debug = Debug("langJs:transpile");

const LOCK_FILE = "/tmp/lang-js-transpile.lock";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So lang-js will sync now on every transpilation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's the idea I'm going for. This is really only a thing in tests and local dev. In prod we run firecracker, so we won't ever have contention on the lang-js binary

@sprutton1
Copy link
Contributor Author

/try

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Okay, starting a try! I'll update this comment once it's running...\n
🚀 Try running here! 🚀

@sprutton1
Copy link
Contributor Author

/try

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Okay, starting a try! I'll update this comment once it's running...\n
🚀 Try running here! 🚀

@sprutton1
Copy link
Contributor Author

/try

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Okay, starting a try! I'll update this comment once it's running...\n
🚀 Try running here! 🚀

@sprutton1 sprutton1 enabled auto-merge January 17, 2025 21:31
@sprutton1 sprutton1 added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@sprutton1 sprutton1 added this pull request to the merge queue Jan 17, 2025
@sprutton1 sprutton1 removed this pull request from the merge queue due to a manual request Jan 17, 2025
@sprutton1 sprutton1 added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 9bf8328 Jan 17, 2025
31 checks passed
@sprutton1 sprutton1 deleted the arm branch January 17, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyhamm zacharyhamm zacharyhamm approved these changes

@johnrwatson johnrwatson johnrwatson left review comments

Assignees
No one assigned
Labels
A-cyclone Area: Function execution engine [Rust] A-lang-js A-veritech Area: Task execution backend service [Rust]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sprutton1 @zacharyhamm @johnrwatson