Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wendy+jacob+nick/eng 2908 users can manage approval requirements #5351

Merged

Conversation

wendybujalski
Copy link
Contributor

@wendybujalski wendybujalski commented Jan 26, 2025

Users can now select a view on the diagram to see its approval requirements.
They can also select "Approval Requirements" from the menu on each view in the LeftPanelDrawer.
Users can add an approval requirement to a view and manage the users who are approvers on that requirement.
While the UI only allows creating one requirement per view for now, it can display multiple requirements if they exist.

Screenshot 2025-01-28 at 11 48 49 AM

Testing steps taken -

Testing with feature flag disabled

  • Disable feature flag for fresh workspace
  • Confirm that the flag is disabled by checking the Admin Dashboard
  • Create a second view
  • Add second view as component to first view
  • Select the second view component - right rail should not change from NoSelectionDetails
  • Open the LeftPanelDrawer and click on the DropdownMenu for a view - there should not be the option "Approval Requirements"

Testing with feature flag enabled

  • Enable feature flag for fresh workspace, join the workspace with 2 separate users (incognito mode is helpful for this!)
  • Confirm that the flag is enabled by checking the Admin Dashboard
  • First user - Create a second and third view
  • First user - Add second and third view as components to first view
  • First user - Select the second view component, the right rail should display ViewDetailsPanel with "No Requirements For This View"
  • Second user - also select the second view component in the same changeset, should see the same as first user
  • First user - use the ViewDetailsPanel to add a requirement, the second user should see it appear as well
  • Second user - add and remove users from the requirement, first user should see the changes in real time
  • First user - swap between selected view components to make sure the info loads properly
  • Finally, delete the requirement, both users should cleanly go back to the empty state for ViewDetailsPanel

@github-actions github-actions bot added A-sdf Area: Primary backend API service [Rust] A-dal A-web labels Jan 26, 2025
@wendybujalski wendybujalski changed the title Wendy/eng 2908 users can see approvers for a view wendy+jacob/eng 2908 users can see approvers for a view Jan 26, 2025
@wendybujalski wendybujalski force-pushed the wendy/eng-2908-users-can-see-approvers-for-a-view branch 2 times, most recently from 70dfe41 to fded267 Compare January 27, 2025 18:34
Copy link

github-actions bot commented Jan 27, 2025

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@wendybujalski wendybujalski force-pushed the wendy/eng-2908-users-can-see-approvers-for-a-view branch from 3949daf to ac82c6f Compare January 27, 2025 22:59
@wendybujalski wendybujalski marked this pull request as ready for review January 27, 2025 23:00
@wendybujalski wendybujalski changed the title wendy+jacob/eng 2908 users can see approvers for a view wendy+jacob+nick/eng 2908 users can see approvers for a view Jan 27, 2025
@wendybujalski wendybujalski force-pushed the wendy/eng-2908-users-can-see-approvers-for-a-view branch 2 times, most recently from 7ee7f4b to ce8aab4 Compare January 28, 2025 00:38
@wendybujalski wendybujalski force-pushed the wendy/eng-2908-users-can-see-approvers-for-a-view branch from 2bf1c1c to 154e361 Compare January 28, 2025 15:07
@wendybujalski wendybujalski changed the title wendy+jacob+nick/eng 2908 users can see approvers for a view wendy+jacob+nick/eng 2908 users can manage approval requirements Jan 28, 2025
@wendybujalski wendybujalski force-pushed the wendy/eng-2908-users-can-see-approvers-for-a-view branch 2 times, most recently from c22f839 to 94417b4 Compare January 28, 2025 18:03
@wendybujalski wendybujalski force-pushed the wendy/eng-2908-users-can-see-approvers-for-a-view branch 4 times, most recently from 0161362 to 683d149 Compare January 28, 2025 21:26
@nickgerace nickgerace marked this pull request as draft January 28, 2025 22:29
@nickgerace
Copy link
Contributor

nickgerace commented Jan 28, 2025

Moving to drafts since we want to adjust the reactivity of the system with the flag on first.

@wendybujalski wendybujalski force-pushed the wendy/eng-2908-users-can-see-approvers-for-a-view branch 3 times, most recently from 294af7e to dae30e3 Compare January 29, 2025 21:00
@wendybujalski wendybujalski marked this pull request as ready for review January 29, 2025 21:08
britmyerss
britmyerss previously approved these changes Jan 29, 2025
Copy link
Contributor

@britmyerss britmyerss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test this locally, left a few comments but mostly nits/no reason to wait. LET'S GOOOOO

@wendybujalski wendybujalski force-pushed the wendy/eng-2908-users-can-see-approvers-for-a-view branch 2 times, most recently from 3b4f941 to 64e9c30 Compare January 29, 2025 22:36
@wendybujalski wendybujalski force-pushed the wendy/eng-2908-users-can-see-approvers-for-a-view branch 2 times, most recently from a629a3c to 05a6d73 Compare January 29, 2025 22:59
Co-authored-by: Nick Gerace <nick@systeminit.com>
Co-authored-by: Jacob Helwig <jacob@systeminit.com>
Co-authored-by: John Obelenus <jobelenus@systeminit.com>
@wendybujalski wendybujalski force-pushed the wendy/eng-2908-users-can-see-approvers-for-a-view branch from 33bad79 to c69c277 Compare January 29, 2025 23:10
@wendybujalski wendybujalski added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 074919b Jan 29, 2025
10 checks passed
@wendybujalski wendybujalski deleted the wendy/eng-2908-users-can-see-approvers-for-a-view branch January 29, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dal A-sdf Area: Primary backend API service [Rust] A-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants