-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wendy+jacob+nick/eng 2908 users can manage approval requirements #5351
Merged
wendybujalski
merged 1 commit into
main
from
wendy/eng-2908-users-can-see-approvers-for-a-view
Jan 29, 2025
Merged
wendy+jacob+nick/eng 2908 users can manage approval requirements #5351
wendybujalski
merged 1 commit into
main
from
wendy/eng-2908-users-can-see-approvers-for-a-view
Jan 29, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-sdf
Area: Primary backend API service [Rust]
A-dal
A-web
labels
Jan 26, 2025
wendybujalski
changed the title
Wendy/eng 2908 users can see approvers for a view
wendy+jacob/eng 2908 users can see approvers for a view
Jan 26, 2025
wendybujalski
force-pushed
the
wendy/eng-2908-users-can-see-approvers-for-a-view
branch
2 times, most recently
from
January 27, 2025 18:34
70dfe41
to
fded267
Compare
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
wendybujalski
force-pushed
the
wendy/eng-2908-users-can-see-approvers-for-a-view
branch
from
January 27, 2025 22:59
3949daf
to
ac82c6f
Compare
wendybujalski
changed the title
wendy+jacob/eng 2908 users can see approvers for a view
wendy+jacob+nick/eng 2908 users can see approvers for a view
Jan 27, 2025
wendybujalski
force-pushed
the
wendy/eng-2908-users-can-see-approvers-for-a-view
branch
2 times, most recently
from
January 28, 2025 00:38
7ee7f4b
to
ce8aab4
Compare
wendybujalski
force-pushed
the
wendy/eng-2908-users-can-see-approvers-for-a-view
branch
from
January 28, 2025 15:07
2bf1c1c
to
154e361
Compare
wendybujalski
changed the title
wendy+jacob+nick/eng 2908 users can see approvers for a view
wendy+jacob+nick/eng 2908 users can manage approval requirements
Jan 28, 2025
nickgerace
reviewed
Jan 28, 2025
wendybujalski
force-pushed
the
wendy/eng-2908-users-can-see-approvers-for-a-view
branch
2 times, most recently
from
January 28, 2025 18:03
c22f839
to
94417b4
Compare
jobelenus
reviewed
Jan 28, 2025
jobelenus
reviewed
Jan 28, 2025
jobelenus
reviewed
Jan 28, 2025
jobelenus
reviewed
Jan 28, 2025
wendybujalski
force-pushed
the
wendy/eng-2908-users-can-see-approvers-for-a-view
branch
4 times, most recently
from
January 28, 2025 21:26
0161362
to
683d149
Compare
Moving to drafts since we want to adjust the reactivity of the system with the flag on first. |
wendybujalski
force-pushed
the
wendy/eng-2908-users-can-see-approvers-for-a-view
branch
3 times, most recently
from
January 29, 2025 21:00
294af7e
to
dae30e3
Compare
britmyerss
reviewed
Jan 29, 2025
britmyerss
reviewed
Jan 29, 2025
britmyerss
reviewed
Jan 29, 2025
britmyerss
reviewed
Jan 29, 2025
britmyerss
previously approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not test this locally, left a few comments but mostly nits/no reason to wait. LET'S GOOOOO
wendybujalski
force-pushed
the
wendy/eng-2908-users-can-see-approvers-for-a-view
branch
2 times, most recently
from
January 29, 2025 22:36
3b4f941
to
64e9c30
Compare
wendybujalski
force-pushed
the
wendy/eng-2908-users-can-see-approvers-for-a-view
branch
2 times, most recently
from
January 29, 2025 22:59
a629a3c
to
05a6d73
Compare
Co-authored-by: Nick Gerace <nick@systeminit.com> Co-authored-by: Jacob Helwig <jacob@systeminit.com> Co-authored-by: John Obelenus <jobelenus@systeminit.com>
wendybujalski
force-pushed
the
wendy/eng-2908-users-can-see-approvers-for-a-view
branch
from
January 29, 2025 23:10
33bad79
to
c69c277
Compare
stack72
approved these changes
Jan 29, 2025
nickgerace
approved these changes
Jan 29, 2025
britmyerss
approved these changes
Jan 29, 2025
wendybujalski
deleted the
wendy/eng-2908-users-can-see-approvers-for-a-view
branch
January 29, 2025 23:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now select a view on the diagram to see its approval requirements.
They can also select "Approval Requirements" from the menu on each view in the LeftPanelDrawer.
Users can add an approval requirement to a view and manage the users who are approvers on that requirement.
While the UI only allows creating one requirement per view for now, it can display multiple requirements if they exist.
Testing steps taken -
Testing with feature flag disabled
Testing with feature flag enabled