This repository has been archived by the owner on Oct 9, 2020. It is now read-only.
buildStatic support for context without a global #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it does not really work atm, I'm going to update the PR as soon as it will also making the tests green. |
chrmod
force-pushed
the
sfx-without-global
branch
from
c38e0fe to
41e329c
Compare
chrmod
force-pushed
the
sfx-without-global
branch
from
191bbab to
d3555a0
Compare
|
the problem was wrong version of uglify-js used for minify.sh |
|
Thanks, I'll post this out with the coming release cycle. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm building a sfx bundle to be run inside of Firefox process script.
In that context, explicit global object (ContentProcessMessageManager) does not happen to accessible via variable.
This PR aims to generate a bundle that will not throw errors on missing global in process script context.
Not sure if using this instead of self or global makes sense, but at least no errors are thrown and bundle works as expected. Please help to improve if there is a way.
Some mozilla docs: