Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commentary on nothing #57

Merged
merged 12 commits into from
Aug 20, 2024
Merged

commentary on nothing #57

merged 12 commits into from
Aug 20, 2024

Conversation

Firgrep
Copy link
Member

@Firgrep Firgrep commented Jul 27, 2024

PR Author's Note

Adds commentary about the category nothing from Burbidge, Houlgate and McTaggart
Added Pinkard's PhS to the bib

checklist below is outdated

Checklist (pick Docs or Code)

  • Docs contribution (philosophy, literature, content)

    •  REQUIRED I accept that my writing is submitted under the ATTRIBUTION-NONCOMMERCIAL-SHAREALIKE 4.0 INTERNATIONAL, which, briefly put, prohibits commercial re-use of the content, but allows sharing, remixing and building upon the material insofar as attribution is given (see legal code), and in this regard I understand that my writing is open to be modified, remixed and build upon by others in the sPhil community within the systemphil/sphil project in future perpetuity.

    •  REQUIRED I have followed the formatting guidelines and verified there are no formatting bugs. Try markdown preview here.

    • REQUIRED I have followed the MLA citation style.

    •  REQUIRED I have added or verified title and description metadata at the very top of the file. Example:

      ---
      title: Hegel Guides
      description: Learn about the philosophy of G. W. F. Hegel
      ---
    • My article is a stub or I want to actively encourage contribution, I've added the Stub component to the bottom of my content but before the bibliography:

      import Stub from "@/components/Stub";
      
      <Stub />;
    • REQUIRED I have added, verified or extended a bibliography. This is added before the authors section and follows MLA guidelines. Example:

      ## Works Cited
      
      <div className="text-sm">
          - Hegel, Friedrich Georg Wilhelm. _The Science of Logic_. Translated
          by George di Giovanni, Cambridge University Press, 2010. - Kant,
          Immanuel. _The Critique of Pure Reason_. Edited by Paul Guyer and
          Allen W. Wood, Cambridge University Press, 1998.
      </div>
    • I have signed the document with my name/username under either as Authors, Editors or Contributors.

      Use Authors if you have created and substantially added content.
      Use Editor if you have made substantial edits or review.
      Use Contributor if you have made minor edits, reviews or contributions.
      If you've done multiple, pick the most weighted: Author > Editor > Contributor.
      If you prefer to remain anonymous, that's fine too, but note that a record of your contributions based on your GitHub username will exist here in the codebase.

      // Bibliography goes here
      
      ---
      
      **Authors**  
      Ahilleas Rokni (2024), Tom Bombadil (2025)
      
      **Contributors**  
      Filip Niklas (2024), Boromir (2025)
    •  If the article makes use of footnotes, I have checked that **Notes** is exactly the very last item in the file.

  • Code contribution (Apache version 2 license)

    All code apart of what is inside src/pages/** (excluding /contributing/**, _app.mdx, _document.tsx, _meta.json, acknowledgements.mdx, index.mdx, privacy.mdx, team.mdx, terms.mdx) is subject to Apache version 2 license. Basically, anything outside of content, literature, philosophy.

@Firgrep Firgrep marked this pull request as ready for review August 2, 2024 16:01
@Firgrep Firgrep marked this pull request as draft August 3, 2024 12:10
@Firgrep Firgrep marked this pull request as ready for review August 4, 2024 13:29
@Firgrep Firgrep requested a review from ridetoruin August 4, 2024 13:29
Copy link
Collaborator

@ridetoruin ridetoruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, a great piece. Aside from a few typos and some points where you could be a bit clearer with your language, it's a great intro to pure nothing.

I also like the way that you included the engagement with the other authors. I think it's an engaging way to do it, and much less heavy than creating other articles.

It's definitely got me interested to contribute my bit on this.

@ridetoruin ridetoruin merged commit 1800c94 into main Aug 20, 2024
2 checks passed
@ridetoruin ridetoruin deleted the docs/firgrep-nothing branch August 20, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants