Saving a profile under the name of another profile causes it to be overwritten

[MarcMichalsky]

If you change the name of a profile to that of another, already existing profile, this other profile is overwritten instead of the current profile.

This is probably due to the fact that the storage of the profiles in a database table was implemented later on.

At least at this place the database ID should be used instead of the profile name:

de.systopia.twingle/CRM/Twingle/Form/Profile.php

Lines 142 to 146 in 518f880

	// Verify that a profile with the given name exists.
	$profile_name = CRM_Utils_Request::retrieve('name', 'String', $this);
	if (!$this->profile = CRM_Twingle_Profile::getProfile($profile_name)) {
	$profile_name = NULL;
	}

I would be happy to fix this, as this bug indirectly affects the implementation of the Twingle Shop #69.

[bjendres]

I would be happy to fix this, as this bug indirectly affects the implementation of the Twingle Shop #69.

You'd be very welcome to do so! Just make sure you catch all the cases :)

But even if you change the primary identifier to the ID, we should still make sure profiles cannot have the same name - but that might already be the case anyway...

[MarcMichalsky]

Well, there is already a mechanism to avoid duplicate names.

But you are right, I will include some additional validation for that – and also for the project_ids which should not be defined in more than one profile.

[bjendres]

I will include some additional validation for that

great.

Just to be sure: you are aware of #42, right?

[MarcMichalsky]

Solved in d9e51c6