Identify profiles by ID #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2023
jensschuppe
requested changes
Aug 16, 2023
jensschuppe
added
enhancement
This was referenced Aug 16, 2023
MarcMichalsky
force-pushed
the
pick_profile_by_id
branch
from
5946754 to
097a4fc
Compare
jensschuppe
force-pushed
the
pick_profile_by_id
branch
from
097a4fc to
5efed1f
Compare
|
@MarcMichalsky I rebased onto current |
jensschuppe
added
status:needs review
|
I'll have a look at it next week. 🏝️ |
jensschuppe
added
status:fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing profiles in a separate db table instead of native CiviCRM settings was implemented in fd47b91.
Nevertheless, the name of the profile is still used to identify it. This leads to problems like #70.
I have now implemented the identification of profiles by their database ID.
This PR depends on PR #72 because it uses the custom
ProfileExceptionclass!