use base64 crate for encoding #29
Conversation
| @@ -40,6 +40,7 @@ deflate = { version = "0.9.1", optional = true } | |||
| sha1 = { version = "0.6.0", features = ["std"] } | |||
| tempfile = "3.2.0" | |||
| futures = "0.3.17" | |||
| base64 = "=0.20.0-alpha.1" | |||
There was a problem hiding this comment.
this is an alpha release, though the author suggests that the API and implementation are stable. I've pinned the version to mitigate any risk here.
| const ENGINE: FastPortable = | ||
| match Alphabet::from_str("0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz-_") { | ||
| Ok(alphabet) => FastPortable::from(&alphabet, fast_portable::PAD), | ||
| Err(_e) => unreachable!(), | ||
| }; |
There was a problem hiding this comment.
this construction is needed since Result::unwrap is not (yet) const
|
Unit test is failing. The padding characters have changed from 00 to ==. Still seems to work, so please fix the unit test to use the new padding characters. |
ah rats. I think I only ran the unit tests in the should be working now |
|
Hi Daniel. Can you resolve the conflicts after my merge of your other PR? |
|
rebased. this is ready for review |
|
Working down the line... You'll have to do some more rebasing I'm afraid. |
use the
base64crate, rather than hand-rolling this